Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the amount of code generated for MTRClusters. #28594

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Reduce the amount of code generated for MTRClusters. #28594

merged 1 commit into from
Aug 9, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

  1. Push endpoint property up to MTRCluster, instead of having it be on every MTRCluster* and MTRBaseCluster* instance.
  2. Instead of duplicating all the command bridge code for MTRCluster* commands, just instantiate the relevant MTRBaseCluster and delegate to it.

@bzbarsky-apple
Reduce the amount of code generated for MTRClusters.
0e8f222 
1. Push endpoint property up to MTRCluster, instead of having it be on every
   MTRCluster* and MTRBaseCluster* instance.
2. Instead of duplicating all the command bridge code for MTRCluster* commands,
   just instantiate the relevant MTRBaseCluster and delegate to it.
@github-actions github-actions bot added the darwin label Aug 9, 2023
@github-actions
Copy link

github-actions bot commented Aug 9, 2023 •
edited
Loading

PR #28594: Size comparison from e2cbb33 to 0e8f222

Increases (16 builds for bl702, bl702l, cyw30739, esp32, k32w, psoc6, telink)
platform target config section e2cbb33 0e8f222 change % change
bl702 lighting-app bl702 (read/write) 1166415 1166419 4 0.0
.debug_info 41506296 41506297 1 0.0
.text 953632 953634 2 0.0
bl702l lighting-app bl702l .debug_info 41507405 41507406 1 0.0
.text 942706 942708 2 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 550199 550207 8 0.0
.app_xip_area 441489 441497 8 0.0
esp32 all-clusters-app c3devkit (read only) 1149626 1149630 4 0.0
.flash.text 1149626 1149630 4 0.0
k32w contact k32w0+release (read only) 590524 590540 16 0.0
.text 589988 590004 16 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 30132757 30132758 1 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27227858 27227859 1 0.0
light cy8ckit_062s2_43012 .debug_info 22370426 22370427 1 0.0
telink bridge-app tlsr9518adk80d text 646946 646948 2 0.0
contact-sensor-app tlsr9518adk80d (read/write) 876076 876084 8 0.0
text 590336 590338 2 0.0
lighting-app tlsr9518adk80d text 685702 685704 2 0.0
lighting-app-rpc tlsr9518adk80d (read/write) 1051900 1051908 8 0.0
text 730634 730638 4 0.0
ota-requestor-app tlsr9518adk80d text 612178 612180 2 0.0
shell tlsr9518adk80d text 478654 478656 2 0.0
temperature-measurement-app tlsr9518adk80d (read/write) 864828 864836 8 0.0
text 582048 582050 2 0.0
window-covering tlsr9518adk80d text 616688 616690 2 0.0
Decreases (12 builds for bl602, bl702, efr32, psoc6, telink)
platform target config section e2cbb33 0e8f222 change % change
bl602 lighting-app bl602 .text 1056656 1056654 -2 -0.0
bl602+rpc .text 1088592 1088590 -2 -0.0
bl702 lighting-app bl702+rpc .debug_info 46400985 46400984 -1 -0.0
.text 1028320 1028318 -2 -0.0
efr32 lighting-app BRD4187C (read/write) 1036604 1036596 -8 -0.0
.text 869228 869220 -8 -0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 22283983 22283982 -1 -0.0
telink all-clusters-app tlsr9518adk80d (read/write) 1070252 1070244 -8 -0.0
text 729058 729056 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d text 669696 669694 -2 -0.0
light-switch-app tlsr9518adk80d (read/write) 907388 907380 -8 -0.0
text 618070 618066 -4 -0.0
lighting-app-factory-data tlsr9518adk80d (read/write) 993740 993732 -8 -0.0
text 693220 693216 -4 -0.0
lock-app tlsr9518adk80d text 621012 621008 -4 -0.0
pump-app tlsr9518adk80d (read/write) 881476 881468 -8 -0.0
text 595938 595936 -2 -0.0
pump-controller-app tlsr9518adk80d (read/write) 868656 868648 -8 -0.0
text 586402 586400 -2 -0.0
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section e2cbb33 0e8f222 change % change
bl602 lighting-app bl602 (read/write) 1363562 1363562 0 0.0
.bss 73622 73622 0 0.0
.data 9560 9560 0 0.0
.text 1056656 1056654 -2 -0.0
bl602+rpc (read/write) 1411030 1411030 0 0.0
.bss 81662 81662 0 0.0
.data 9952 9952 0 0.0
.text 1088592 1088590 -2 -0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1166415 1166419 4 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 41285 41285 0 0.0
.bss_psram 43424 43424 0 0.0
.comment 48 48 0 0.0
.data 3544 3544 0 0.0
.debug_abbrev 1567344 1567344 0 0.0
.debug_aranges 140376 140376 0 0.0
.debug_frame 516556 516556 0 0.0
.debug_info 41506296 41506297 1 0.0
.debug_line 5483788 5483788 0 0.0
.debug_loc 3564500 3564500 0 0.0
.debug_ranges 384456 384456 0 0.0
.debug_str 4012273 4012273 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106856 106856 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 589203 589203 0 0.0
.symtab 175568 175568 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
953632 953634 2 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1265355 1265355 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 49749 49749 0 0.0
.bss_psram 43424 43424 0 0.0
.comment 48 48 0 0.0
.data 4104 4104 0 0.0
.debug_abbrev 1744474 1744474 0 0.0
.debug_aranges 148920 148920 0 0.0
.debug_frame 545460 545460 0 0.0
.debug_info 46400985 46400984 -1 -0.0
.debug_line 5896310 5896310 0 0.0
.debug_loc 3770656 3770656 0 0.0
.debug_ranges 410208 410208 0 0.0
.debug_str 4432138 4432138 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121508 121508 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 652166 652166 0 0.0
.symtab 194496 194496 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1028320 1028318 -2 -0.0
bl702l lighting-app bl702l (read only) 278 278 0 0.0
(read/write) 1152348 1152348 0 0.0
.boot2 292 292 0 0.0
.bss 15988 15988 0 0.0
.bss_psram 77840 77840 0 0.0
.comment 48 48 0 0.0
.data 4528 4528 0 0.0
.debug_abbrev 1569563 1569563 0 0.0
.debug_aranges 134880 134880 0 0.0
.debug_frame 496244 496244 0 0.0
.debug_info 41507405 41507406 1 0.0
.debug_line 5399482 5399482 0 0.0
.debug_loc 3500683 3500683 0 0.0
.debug_ranges 389664 389664 0 0.0
.debug_str 4024742 4024742 0 0.0
.hbn 3244 3244 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 144 144 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 100740 100740 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 286 286 0 0.0
.stack 2048 2048 0 0.0
.strtab 589428 589428 0 0.0
.symtab 175136 175136 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 278 278 0 0.0
.text 0 0 0 0.0
942706 942708 2 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 615642 615642 0 0.0
(read/write) 207744 207744 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 201184 201184 0 0.0
.comment 206 206 0 0.0
.data 1440 1440 0 0.0
.debug_abbrev 961965 961965 0 0.0
.debug_aranges 109048 109048 0 0.0
.debug_frame 369816 369816 0 0.0
.debug_info 19420894 19420894 0 0.0
.debug_line 2813775 2813775 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1596773 1596773 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 100571 100571 0 0.0
.debug_str 3426976 3426976 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106282 106282 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 496303 496303 0 0.0
.symtab 293312 293312 0 0.0
.text 507240 507240 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 550199 550207 8 0.0
.app_xip_area 441489 441497 8 0.0
.bss 63728 63728 0 0.0
.data 664 664 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 537287 537287 0 0.0
.app_xip_area 423529 423529 0 0.0
.bss 68752 68752 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 573991 573991 0 0.0
.app_xip_area 466361 466361 0 0.0
.bss 62720 62720 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 548943 548943 0 0.0
.app_xip_area 438305 438305 0 0.0
.bss 65632 65632 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1012028 1012028 0 0.0
.bss 184524 184524 0 0.0
.data 2652 2652 0 0.0
.text 824832 824832 0 0.0
BRD4187C (read/write) 1036604 1036596 -8 -0.0
.bss 164108 164108 0 0.0
.data 3248 3248 0 0.0
.text 869228 869220 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1088760 1088760 0 0.0
.bss 178580 178580 0 0.0
.data 2672 2672 0 0.0
.text 907488 907488 0 0.0
window-app BRD4187C (read/write) 1108064 1108064 0 0.0
.bss 147148 147148 0 0.0
.data 3132 3132 0 0.0
.text 957764 957764 0 0.0
esp32 all-clusters-app c3devkit (read only) 1149626 1149630 4 0.0
(read/write) 1701964 1701964 0 0.0
.dram0.bss 79048 79048 0 0.0
.dram0.data 13076 13076 0 0.0
.flash.rodata 266088 266088 0 0.0
.flash.text 1149626 1149630 4 0.0
.iram0.text 75262 75262 0 0.0
m5stack (read only) 1191487 1191487 0 0.0
(read/write) 550174 550174 0 0.0
.dram0.bss 85416 85416 0 0.0
.dram0.data 34036 34036 0 0.0
.flash.rodata 297080 297080 0 0.0
.flash.text 1186103 1186103 0 0.0
.iram0.text 123311 123311 0 0.0
k32w contact k32w0+release (read only) 590524 590540 16 0.0
(read/write) 91272 91272 0 0.0
.bss 67316 67316 0 0.0
.data 2124 2124 0 0.0
.text 589988 590004 16 0.0
light k32w0+release (read only) 589148 589148 0 0.0
(read/write) 90912 90912 0 0.0
.bss 66972 66972 0 0.0
.data 2112 2112 0 0.0
.text 588612 588612 0 0.0
lock k32w0+release (read only) 561716 561716 0 0.0
(read/write) 88736 88736 0 0.0
.bss 64852 64852 0 0.0
.data 2056 2056 0 0.0
.text 561180 561180 0 0.0
linux all-clusters-app debug (read only) 5487297 5487297 0 0.0
(read/write) 417632 417632 0 0.0
.bss 130400 130400 0 0.0
.data 4016 4016 0 0.0
.data.rel.ro 275872 275872 0 0.0
.dynamic 624 624 0 0.0
.got 5384 5384 0 0.0
.init 27 27 0 0.0
.init_array 1304 1304 0 0.0
.rodata 334032 334032 0 0.0
.text 4776211 4776211 0 0.0
all-clusters-minimal-app debug (read only) 4901129 4901129 0 0.0
(read/write) 231384 231384 0 0.0
.bss 126016 126016 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 94376 94376 0 0.0
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 271878 271878 0 0.0
.text 4399075 4399075 0 0.0
bridge-app debug (read only) 2768945 2768945 0 0.0
(read/write) 132816 132816 0 0.0
.bss 51480 51480 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 71400 71400 0 0.0
.dynamic 624 624 0 0.0
.got 4640 4640 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 214440 214440 0 0.0
.text 2376979 2376979 0 0.0
chip-tool debug (read only) 17605649 17605649 0 0.0
(read/write) 1046144 1046144 0 0.0
.bss 93752 93752 0 0.0
.data 5090 5090 0 0.0
.data.rel.ro 939952 939952 0 0.0
.dynamic 624 624 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 900209 900209 0 0.0
.text 14672035 14672035 0 0.0
chip-tool-ipv6only arm64 (read only) 16838788 16838788 0 0.0
(read/write) 1113528 1113528 0 0.0
.bss 103064 103064 0 0.0
.data 4392 4392 0 0.0
.data.rel.ro 977304 977304 0 0.0
.dynamic 512 512 0 0.0
.got 23272 23272 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 812384 812384 0 0.0
.text 13808472 13808472 0 0.0
lighting-app debug+rpc+ui (read only) 5240401 5240401 0 0.0
(read/write) 222056 222056 0 0.0
.bss 117712 117712 0 0.0
.data 4528 4528 0 0.0
.data.rel.ro 92240 92240 0 0.0
.dynamic 672 672 0 0.0
.got 5928 5928 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 336948 336948 0 0.0
.text 4661379 4661379 0 0.0
lock-app debug (read only) 4471377 4471377 0 0.0
(read/write) 202808 202808 0 0.0
.bss 113328 113328 0 0.0
.data 3728 3728 0 0.0
.data.rel.ro 78960 78960 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 247782 247782 0 0.0
.text 4014243 4014243 0 0.0
ota-provider-app debug (read only) 4127561 4127561 0 0.0
(read/write) 191872 191872 0 0.0
.bss 113504 113504 0 0.0
.data 4000 4000 0 0.0
.data.rel.ro 68448 68448 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 200966 200966 0 0.0
.text 3736275 3736275 0 0.0
ota-requestor-app debug (read only) 4221505 4221505 0 0.0
(read/write) 196184 196184 0 0.0
.bss 114560 114560 0 0.0
.data 4240 4240 0 0.0
.data.rel.ro 71448 71448 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 204390 204390 0 0.0
.text 3822467 3822467 0 0.0
shell debug (read only) 2930337 2930337 0 0.0
(read/write) 150688 150688 0 0.0
.bss 60008 60008 0 0.0
.data 784 784 0 0.0
.data.rel.ro 84024 84024 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 210674 210674 0 0.0
.text 2548770 2548770 0 0.0
thermostat-no-ble arm64 (read only) 4450452 4450452 0 0.0
(read/write) 243848 243848 0 0.0
.bss 122280 122280 0 0.0
.data 2880 2880 0 0.0
.data.rel.ro 102232 102232 0 0.0
.dynamic 512 512 0 0.0
.got 11984 11984 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 161996 161996 0 0.0
.text 3950376 3950376 0 0.0
tv-app debug (read only) 5315697 5315697 0 0.0
(read/write) 349856 349856 0 0.0
.bss 241280 241280 0 0.0
.data 5104 5104 0 0.0
.data.rel.ro 96048 96048 0 0.0
.dynamic 624 624 0 0.0
.got 5616 5616 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 272374 272374 0 0.0
.text 4799683 4799683 0 0.0
tv-casting-app debug (read only) 8295105 8295105 0 0.0
(read/write) 210568 210568 0 0.0
.bss 54208 54208 0 0.0
.data 2544 2544 0 0.0
.data.rel.ro 147016 147016 0 0.0
.dynamic 624 624 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 367644 367644 0 0.0
.text 7527299 7527299 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2522144 2522144 0 0.0
.bss 219904 219904 0 0.0
.data 5128 5128 0 0.0
.text 1484828 1484828 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1218724 1218724 0 0.0
bss 154612 154612 0 0.0
rodata 141392 141392 0 0.0
text 843776 843776 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1337436 1337436 0 0.0
bss 140070 140070 0 0.0
rodata 135484 135484 0 0.0
text 771192 771192 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1156764 1156764 0 0.0
bss 154791 154791 0 0.0
rodata 112776 112776 0 0.0
text 810212 810212 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 837696 837696 0 0.0
(read/write) 1766788 1766788 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 193116 193116 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2528 2528 0 0.0
.debug_abbrev 1378683 1378683 0 0.0
.debug_aranges 143904 143904 0 0.0
.debug_frame 479288 479288 0 0.0
.debug_info 30132757 30132758 1 0.0
.debug_line 4143196 4143196 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2248217 2248217 0 0.0
.debug_rnglists 142353 142353 0 0.0
.debug_str 4120936 4120936 0 0.0
.heap 837696 837696 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 802679 802679 0 0.0
.symtab 500160 500160 0 0.0
.text 1562756 1562756 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 839648 839648 0 0.0
(read/write) 1674236 1674236 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 191228 191228 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1285068 1285068 0 0.0
.debug_aranges 137200 137200 0 0.0
.debug_frame 462360 462360 0 0.0
.debug_info 27227858 27227859 1 0.0
.debug_line 3961044 3961044 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2148948 2148948 0 0.0
.debug_rnglists 135480 135480 0 0.0
.debug_str 3979198 3979198 0 0.0
.heap 839648 839648 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 713312 713312 0 0.0
.symtab 465808 465808 0 0.0
.text 1472156 1472156 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 845912 845912 0 0.0
(read/write) 1605732 1605732 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185076 185076 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2352 2352 0 0.0
.debug_abbrev 1125291 1125291 0 0.0
.debug_aranges 127328 127328 0 0.0
.debug_frame 425504 425504 0 0.0
.debug_info 22370426 22370427 1 0.0
.debug_line 3526349 3526349 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 1986063 1986063 0 0.0
.debug_rnglists 125250 125250 0 0.0
.debug_str 3787270 3787270 0 0.0
.heap 845912 845912 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 634304 634304 0 0.0
.symtab 430448 430448 0 0.0
.text 1409916 1409916 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 818392 818392 0 0.0
(read/write) 1639236 1639236 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 212580 212580 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2368 2368 0 0.0
.debug_abbrev 1116755 1116755 0 0.0
.debug_aranges 126240 126240 0 0.0
.debug_frame 421532 421532 0 0.0
.debug_info 22283983 22283982 -1 -0.0
.debug_line 3481800 3481800 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 1966472 1966472 0 0.0
.debug_rnglists 123426 123426 0 0.0
.debug_str 3751808 3751808 0 0.0
.heap 818392 818392 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 608204 608204 0 0.0
.symtab 422576 422576 0 0.0
.text 1415900 1415900 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1177860 1177860 0 0.0
.bss 101176 101176 0 0.0
.data 744 744 0 0.0
.text 624704 624704 0 0.0
lock-app qpg6105+debug (read/write) 1134932 1134932 0 0.0
.bss 95896 95896 0 0.0
.data 748 748 0 0.0
.text 581772 581772 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1070252 1070244 -8 -0.0
bss 107308 107308 0 0.0
text 729058 729056 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 976720 976720 0 0.0
bss 105284 105284 0 0.0
text 669696 669694 -2 -0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 944120 944120 0 0.0
bss 109660 109660 0 0.0
text 646946 646948 2 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 876076 876084 8 0.0
bss 98840 98840 0 0.0
text 590336 590338 2 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 907388 907380 -8 -0.0
bss 99464 99464 0 0.0
text 618070 618066 -4 -0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 982376 982376 0 0.0
bss 107516 107516 0 0.0
text 685702 685704 2 0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 993740 993732 -8 -0.0
bss 111764 111764 0 0.0
text 693220 693216 -4 -0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1051900 1051908 8 0.0
bss 109088 109088 0 0.0
text 730634 730638 4 0.0
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1083228 1083228 0 0.0
bss 120164 120164 0 0.0
text 750740 750740 0 0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 933528 933528 0 0.0
bss 99560 99560 0 0.0
text 621012 621008 -4 -0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 898656 898656 0 0.0
bss 100148 100148 0 0.0
text 612178 612180 2 0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 881476 881468 -8 -0.0
bss 98972 98972 0 0.0
text 595938 595936 -2 -0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 868656 868648 -8 -0.0
bss 98772 98772 0 0.0
text 586402 586400 -2 -0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 744196 744196 0 0.0
bss 97208 97208 0 0.0
text 478654 478656 2 0.0
smoke_co_alarm-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 878560 878560 0 0.0
bss 98952 98952 0 0.0
text 593812 593812 0 0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 864828 864836 8 0.0
bss 98680 98680 0 0.0
text 582048 582050 2 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 910668 910668 0 0.0
bss 99224 99224 0 0.0
text 621382 621382 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 906456 906456 0 0.0
bss 99560 99560 0 0.0
text 616688 616690 2 0.0

@mergify mergify bot merged commit 4111aac into project-chip:master Aug 9, 2023
@bzbarsky-apple bzbarsky-apple deleted the less-MTRClusters-code branch August 9, 2023 14:42
abpoth pushed a commit to abpoth/connectedhomeip that referenced this pull request Aug 15, 2023
@bzbarsky-apple
Reduce the amount of code generated for MTRClusters. (project-chip#28594
fc04475 
)

1. Push endpoint property up to MTRCluster, instead of having it be on every
   MTRCluster* and MTRBaseCluster* instance.
2. Instead of duplicating all the command bridge code for MTRCluster* commands,
   just instantiate the relevant MTRBaseCluster and delegate to it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksperling-apple ksperling-apple ksperling-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

Assignees
No one assigned
Labels
darwin review - approved
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @yunhanw-google @ksperling-apple