-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32]: Add way to configure BLE scan response. #28571
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jadhavrohit924
commented
Aug 8, 2023
- Problem
- Changes
- Testing
github-actions
bot
added
documentation
Improvements or additions to documentation
platform
esp32
labels
Aug 8, 2023
jadhavrohit924
force-pushed
the
scan-response
branch
from
August 8, 2023 06:58
501c690
to
bdeec26
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
August 8, 2023 06:59
PR #28571: Size comparison from 367a0c6 to 61c6fd5 Increases (8 builds for cyw30739, esp32, psoc6, telink)
Decreases (17 builds for bl602, bl702, bl702l, cc32xx, efr32, nrfconnect, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
shubhamdp
reviewed
Aug 8, 2023
PR #28571: Size comparison from 367a0c6 to 0fcabc3 Increases (11 builds for cyw30739, esp32, linux, psoc6, telink)
Decreases (17 builds for bl602, bl702, cc32xx, efr32, k32w, nrfconnect, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
dhrishi
reviewed
Aug 10, 2023
dhrishi
changed the title
[ESP32]: Add way to configure scan response.
[ESP32]: Add way to configure BLE scan response.
Aug 10, 2023
jadhavrohit924
force-pushed
the
scan-response
branch
from
August 10, 2023 04:35
0fcabc3
to
15f4b3f
Compare
PR #28571: Size comparison from a3c4b48 to 15f4b3f Increases (15 builds for bl602, bl702, esp32, mbed, psoc6, telink)
Decreases (9 builds for bl702l, efr32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jadhavrohit924
force-pushed
the
scan-response
branch
from
August 10, 2023 09:17
15f4b3f
to
186faa5
Compare
shubhamdp
approved these changes
Aug 10, 2023
PR #28571: Size comparison from a3c4b48 to 186faa5 Increases (1 build for mbed)
Full report (2 builds for cc32xx, mbed)
|
jadhavrohit924
force-pushed
the
scan-response
branch
from
August 10, 2023 09:37
186faa5
to
215d868
Compare
PR #28571: Size comparison from 4c03e50 to 215d868 Increases (10 builds for cc32xx, esp32, telink)
Decreases (8 builds for bl702, bl702l, efr32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
dhrishi
approved these changes
Aug 11, 2023
jmartinez-silabs
approved these changes
Aug 14, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 15, 2023
* [ESP32]: Add way to configure scan response. * Restyled by prettier-markdown * Address review comments --------- Co-authored-by: Restyled.io <[email protected]>
s07641069
pushed a commit
to s07641069/connectedhomeip
that referenced
this pull request
Aug 22, 2023
* [ESP32]: Add way to configure scan response. * Restyled by prettier-markdown * Address review comments --------- Co-authored-by: Restyled.io <[email protected]>
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* [ESP32]: Add way to configure scan response. * Restyled by prettier-markdown * Address review comments --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.