-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TC-PS-3.1: Add cluster revision check #28482
Merged
mergify
merged 4 commits into
project-chip:master
from
cecille:power_source_endpoint_list_check_revision
Aug 8, 2023
Merged
TC-PS-3.1: Add cluster revision check #28482
mergify
merged 4 commits into
project-chip:master
from
cecille:power_source_endpoint_list_check_revision
Aug 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the test suite to be dual-purposed against existing devices in the field as well as being used for cert. Correct cluster revision for cert testing purposes is tested in the TC-PS-1.1 test. Test: Down-rev'd one PS cluster on all clusters and removed EndpointList - saw note, test passes.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
August 2, 2023 21:21
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
August 2, 2023 21:21
PR #28482: Size comparison from 7f99c44 to c9bbcb7 Increases (9 builds for bl702, bl702l, cyw30739, k32w, psoc6, telink)
Decreases (9 builds for bl602, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28482: Size comparison from 7f99c44 to 8b3c2bb Increases (6 builds for bl702l, cyw30739, esp32, psoc6, telink)
Decreases (12 builds for bl602, bl702, cc32xx, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28482: Size comparison from 7f99c44 to bd4ffd5 Increases above 0.2%:
Increases (25 builds for bl602, bl702, bl702l, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
Decreases (25 builds for bl602, bl702, bl702l, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
Full report (25 builds for bl602, bl702, bl702l, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #28482: Size comparison from b3d3685 to dc824a1 Increases (6 builds for cyw30739, psoc6, telink)
Decreases (15 builds for bl602, bl702, bl702l, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Aug 5, 2023
andy31415
approved these changes
Aug 8, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 15, 2023
* TC-PS-3.1: Add cluster revision check This allows the test suite to be dual-purposed against existing devices in the field as well as being used for cert. Correct cluster revision for cert testing purposes is tested in the TC-PS-1.1 test. Test: Down-rev'd one PS cluster on all clusters and removed EndpointList - saw note, test passes. * appease the linter * Change location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the test suite to be dual-purposed against existing devices in the field as well as being used for cert. Correct cluster revision for cert testing purposes is tested in the TC-PS-1.1 test.
Test: Down-rev'd one PS cluster on all clusters and removed
EndpointList - saw note, test passes.
Fixes: #28458