-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Subscription report emission when becoming active #28266
Merged
mergify
merged 10 commits into
project-chip:master
from
lpbeliveau-silabs:feature/icd_manager_trigger_reports_on_wake
Aug 1, 2023
Merged
[ICD] Subscription report emission when becoming active #28266
mergify
merged 10 commits into
project-chip:master
from
lpbeliveau-silabs:feature/icd_manager_trigger_reports_on_wake
Aug 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
LuDuda,
mhazley and
mkardous-silabs
July 25, 2023 13:54
woody-apple
approved these changes
Jul 25, 2023
mkardous-silabs
requested changes
Jul 25, 2023
PR #28266: Size comparison from f2fc1a2 to a0a5674 Increases (15 builds for bl702, bl702l, cc32xx, nrfconnect, psoc6, telink)
Decreases (18 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, psoc6, qpg, telink)
Full report (45 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
mkardous-silabs
approved these changes
Jul 25, 2023
PR #28266: Size comparison from f2fc1a2 to 821dce2 Increases above 0.2%:
Increases (22 builds for bl702, bl702l, cc32xx, cyw30739, efr32, k32w, nrfconnect, psoc6, telink)
Decreases (20 builds for bl602, bl702, bl702l, cc32xx, efr32, nrfconnect, psoc6, qpg, telink)
Full report (45 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
…ject the scheduler in the ICD manager from Server::Init()
Co-authored-by: Boris Zbarsky <[email protected]>
…s in app/BUILD.gn
lpbeliveau-silabs
force-pushed
the
feature/icd_manager_trigger_reports_on_wake
branch
from
July 27, 2023 19:18
821dce2
to
36cf916
Compare
PR #28266: Size comparison from 0b506e5 to 36cf916 Increases (2 builds for cc32xx, mbed)
Decreases (1 build for cc32xx)
Full report (2 builds for cc32xx, mbed)
|
PR #28266: Size comparison from 0b506e5 to d89eb8d Increases above 0.2%:
Increases (59 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for cc32xx, linux, psoc6)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Co-authored-by: Boris Zbarsky <[email protected]>
…ved misleading comment
lpbeliveau-silabs
deleted the
feature/icd_manager_trigger_reports_on_wake
branch
December 10, 2024 14:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an OnActiveModeEntered in ReportScheduler that can be called from the ICD manager to schedule a report emission.
The reports will be scheduled according to the reporting intervals and the IsDirty condition.
fixes #28126