-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppDelegate updates: new callback and docs #28240
Merged
sharadb-amazon
merged 7 commits into
project-chip:master
from
sharadb-amazon:appd-20230724
Jul 26, 2023
Merged
AppDelegate updates: new callback and docs #28240
sharadb-amazon
merged 7 commits into
project-chip:master
from
sharadb-amazon:appd-20230724
Jul 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharadb-amazon
requested review from
tcarmelveilleux,
chrisdecenzo,
bzbarsky-apple and
cliffamzn
July 24, 2023 22:08
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
July 24, 2023 22:08
cliffamzn
approved these changes
Jul 24, 2023
PR #28240: Size comparison from fe4c679 to 42f6eae Increases (56 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (1 build for telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Jul 25, 2023
PR #28240: Size comparison from fe4c679 to 19f6b95 Increases above 0.2%:
Increases (59 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for linux, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
sharadb-amazon
force-pushed
the
appd-20230724
branch
from
July 25, 2023 20:20
19f6b95
to
494bbc9
Compare
PR #28240: Size comparison from 42e6f43 to 494bbc9 Increases (39 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg)
Full report (42 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
tcarmelveilleux
approved these changes
Jul 25, 2023
bzbarsky-apple
requested changes
Jul 26, 2023
sharadb-amazon
force-pushed
the
appd-20230724
branch
from
July 26, 2023 20:30
1574e20
to
dc25949
Compare
PR #28240: Size comparison from 7ab043c to dc25949 Increases (8 builds for cc32xx, k32w, nrfconnect, qpg)
Full report (10 builds for cc32xx, k32w, mbed, nrfconnect, qpg)
|
bzbarsky-apple
approved these changes
Jul 26, 2023
Co-authored-by: Boris Zbarsky <[email protected]>
PR #28240: Size comparison from 7ab043c to 5229056 Increases (53 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
sharadb-amazon
added a commit
to sharadb-amazon/connectedhomeip
that referenced
this pull request
Aug 1, 2023
* Adding OnCommissioningSessionEstablishmentError(err) to AppDelegate * Removed error param from OnCommissioningSessionStopped and added docs for all of AppDelegate * Addressing feedback from tcarmelveilleux@ * Revert "Addressing feedback from tcarmelveilleux@" This reverts commit 494bbc9. * Addressing feedback from bzbarsky-apple@ * Update src/app/server/AppDelegate.h Co-authored-by: Boris Zbarsky <[email protected]> * Restyled --------- Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bullet # 1 of #28230
Problem
Change summary