-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed zap development install from chip-cert-bins
docker image.
#28223
Merged
woody-apple
merged 1 commit into
project-chip:master
from
mikaelhm:fix/remove-zap-development-install-from-csg-chip-cert-bins-dockerfile
Jul 25, 2023
Merged
Removed zap development install from chip-cert-bins
docker image.
#28223
woody-apple
merged 1 commit into
project-chip:master
from
mikaelhm:fix/remove-zap-development-install-from-csg-chip-cert-bins-dockerfile
Jul 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`zap` is now available as arm64 binaries, and bootstrap will take care of installing it.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
July 24, 2023 17:58
pullapprove
bot
requested review from
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley,
mkardous-silabs,
mlepage-google,
mrjerryjohns,
mspang,
nivi-apple,
p0fi,
plauric,
rcasallas-silabs,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yufengwangca
July 24, 2023 17:58
PR #28223: Size comparison from d328c30 to e9c61a0 Increases (4 builds for esp32, telink)
Decreases (18 builds for bl602, bl702, bl702l, cyw30739, esp32, nrfconnect, psoc6, qpg, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jul 24, 2023
cliffamzn
pushed a commit
to cliffamzn/connectedhomeip
that referenced
this pull request
Jul 25, 2023
`zap` is now available as arm64 binaries, and bootstrap will take care of installing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
nodejs
,npm
and the development install ofzap
in thechip-cert-bins
docker image.These can be removed now that
zap
is available as arm64 binaries, and bootstrap will take care of installing it."Manually verified that
chip-cert-bins
docker image still builds.