Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ZAP to pick up swiftUnavailable changes. #28085

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integrations/docker/images/chip-cert-bins/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ ARG COMMITHASH=7b99e6399c6069037c613782d78132c69b9dcabb
# ZAP Development install, so that it runs on both x64 and arm64
# Generally this should match with the ZAP version that is used for codegen within the
# specified SHA
ARG ZAP_VERSION=v2023.05.22-nightly
ARG ZAP_VERSION=v2023.07.19-nightly

# Ensure TARGETPLATFORM is set
RUN case ${TARGETPLATFORM} in \
Expand Down
4 changes: 2 additions & 2 deletions scripts/setup/zap.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@
"mac-amd64",
"windows-amd64"
],
"tags": ["version:2@v2023.05.22-nightly.1"]
"tags": ["version:2@v2023.07.19-nightly.1"]
},
{
"_comment": "Always get the amd64 version on mac until usable arm64 zap build is available",
"path": "fuchsia/third_party/zap/mac-amd64",
"platforms": ["mac-arm64"],
"tags": ["version:2@v2023.05.22-nightly.1"]
"tags": ["version:2@v2023.07.19-nightly.1"]
}
]
}
2 changes: 1 addition & 1 deletion scripts/setup/zap.version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v2023.05.22-nightly
v2023.07.19-nightly
2 changes: 1 addition & 1 deletion scripts/tools/zap/zap_execution.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
# Use scripts/tools/zap/version_update.py to manage ZAP versioning as many
# files may need updating for versions
#
MIN_ZAP_VERSION = '2023.5.22'
MIN_ZAP_VERSION = '2023.7.19'


class ZapTool:
Expand Down
19 changes: 19 additions & 0 deletions src/darwin/Framework/CHIP/templates/availability.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,13 @@
# Please examine codegen carefully when using "removed" to make
# sure all the things that should have been removed have been.
#
# * "swiftUnavailable": Can contain clusters, commands, attributes, etc as
# described above for "introduced" and "deprecated". This
# can be used to mark APIs with NS_SWIFT_UNAVAILABLE,
# typically when an API was renamed between two names that
# map to the same Swift name and then both names were
# deprecated.
#
# * "provisional": Can contain clusters, commands, attributes, etc as described
# above for "introduced" and "deprecated". Items can be
# defined as provisional to prevent code generation for them.
Expand Down Expand Up @@ -7394,6 +7401,18 @@
ModeSelect:
Feature:
OnOff: DEPONOFF
swiftUnavailable:
bitmap values:
NetworkCommissioning:
WiFiSecurity:
# The bitmap got renamed to WiFiSecurityBitmap, so now both
# the Wpa* and WPA* names on WiFiSecurity are deprecated.
# They get mapped to Swift with identical names, which leads
# to the names being ambiguous. Mark the "Wpa*" as
# unavailable to Swift to work around this.
- WpaPersonal
- Wpa2Personal
- Wpa3Personal
provisional:
clusters:
## Not ready at cutoff
Expand Down
5 changes: 3 additions & 2 deletions src/darwin/Framework/CHIP/zap-generated/MTRBaseClusters.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.