[matter_yamltests] Add an implicit rule that the key 'value' in argum… #28068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
pullapprove
bot
requested review from
mspang,
nivi-apple,
p0fi,
plauric,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vijs,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
woody-apple
approved these changes
Jul 19, 2023
bzbarsky-apple
approved these changes
Jul 19, 2023
andy31415
approved these changes
Jul 19, 2023
…ents can not be used if the command is not a 'writeAttribute'
vivien-apple
force-pushed
the
MatterYamlTests_ImplicitArgumentValueRule
branch
from
654e7e0 to
3dd7d20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ents can not be used if the command is not a 'writeAttribute'
Problem
If someone write a yaml test and use the 'value' key in 'arguments' but the command is not 'writeAttribute' it will fails with a cryptic error.
This PR makes it clear by explaining the error and showing the related keys.