Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP32: Do not read the ap record if esp_wifi_scan_start() is not called by NetworkCommissioningDriver [Cherrypick 27161] #28045

Merged
merged 1 commit into from
Mar 12, 2024
Merged

ESP32: Do not read the ap record if esp_wifi_scan_start() is not called by NetworkCommissioningDriver [Cherrypick 27161] #28045

merged 1 commit into from
Mar 12, 2024

Conversation

wqx6
Copy link
Contributor

@wqx6 wqx6 commented Jul 19, 2023

Cherrypick of #27161

@chshu chshu force-pushed the cherrypick-27161 branch from f5fe8cf to 24d84a1 Compare August 22, 2023 04:18
@github-actions
Copy link

github-actions bot commented Aug 22, 2023 •
edited
Loading

PR #28045: Size comparison from 910be1f to 24d84a1

Increases (3 builds for cyw30739, nrfconnect, psoc6)
platform target config section 910be1f 24d84a1 change % change
cyw30739 switch cyw930739m2evb_01 (read/write) 530547 530555 8 0.0
.app_xip_area 421541 421549 8 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 808892 808896 4 0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22155370 22155372 2 0.0
Decreases (9 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, psoc6)
platform target config section 910be1f 24d84a1 change % change
bl602 lighting-app bl602 .text 1037240 1037236 -4 -0.0
bl602+rpc (read/write) 1402790 1402782 -8 -0.0
.text 1068594 1068592 -2 -0.0
bl702 lighting-app bl702+rpc .debug_info 45455700 45455699 -1 -0.0
.text 1038742 1038740 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 680887 680879 -8 -0.0
.text 593356 593348 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 677971 677963 -8 -0.0
.text 591768 591760 -8 -0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 1953006 19530065 -1 -0.0
cyw30739 ota-requestor cyw930739m2evb_01 (read/write) 566187 566179 -8 -0.0
.app_xip_area 459733 459725 -8 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27087589 27087588 -1 -0.0
lock cy8ckit_062s2_43012 .debug_info 22333534 22333533 -1 -0.0
Full report (30 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, k32w, linux, nrfconnect, psoc6, qpg)
platform target config section 910be1f 24d84a1 change % change
bl602 lighting-app bl602 (read/write) 1356514 1356514 0 0.0
.bss 87902 87902 0 0.0
.data 9648 9648 0 0.0
.text 1037240 1037236 -4 -0.0
bl602+rpc (read/write) 1402790 1402782 -8 -0.0
.bss 95950 95950 0 0.0
.data 10040 10040 0 0.0
.text 1068594 1068592 -2 -0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1186895 1186895 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67601 67601 0 0.0
.bss_psram 24368 24368 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1553568 1553568 0 0.0
.debug_aranges 132752 132752 0 0.0
.debug_frame 487676 487676 0 0.0
.debug_info 40760120 40760120 0 0.0
.debug_line 5296780 5296780 0 0.0
.debug_loc 3421500 3421500 0 0.0
.debug_ranges 375696 375696 0 0.0
.debug_str 3676322 3676322 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106544 106544 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 580826 580826 0 0.0
.symtab 175184 175184 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
966348 966348 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1274451 1274451 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75633 75633 0 0.0
.bss_psram 24768 24768 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1706934 1706934 0 0.0
.debug_aranges 140976 140976 0 0.0
.debug_frame 515568 515568 0 0.0
.debug_info 45455700 45455699 -1 -0.0
.debug_line 5706210 5706210 0 0.0
.debug_loc 3622594 3622594 0 0.0
.debug_ranges 400728 400728 0 0.0
.debug_str 4100731 4100731 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 120384 120384 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 641370 641370 0 0.0
.symtab 193472 193472 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1038742 1038740 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 680887 680879 -8 -0.0
(read/write) 158660 158660 0 0.0
.bss 81232 81232 0 0.0
.data 3316 3316 0 0.0
.rodata 87207 87207 0 0.0
.text 593356 593348 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 644935 644935 0 0.0
(read/write) 157860 157860 0 0.0
.bss 80432 80432 0 0.0
.data 3316 3316 0 0.0
.rodata 76999 76999 0 0.0
.text 567616 567616 0 0.0
lock-ftd LP_CC2652R7 (read only) 680031 680031 0 0.0
(read/write) 156144 156144 0 0.0
.bss 78752 78752 0 0.0
.data 3280 3280 0 0.0
.rodata 75871 75871 0 0.0
.text 603672 603672 0 0.0
lock-mtd LP_CC2652R7 (read only) 667475 667475 0 0.0
(read/write) 151320 151320 0 0.0
.bss 73928 73928 0 0.0
.data 3280 3280 0 0.0
.rodata 102659 102659 0 0.0
.text 564328 564328 0 0.0
pump-app LP_CC2652R7 (read only) 692499 692499 0 0.0
(read/write) 156588 156588 0 0.0
.bss 78720 78720 0 0.0
.data 3244 3244 0 0.0
.rodata 89947 89947 0 0.0
.text 602064 602064 0 0.0
pump-controller-app LP_CC2652R7 (read only) 677971 677963 -8 -0.0
(read/write) 157004 157004 0 0.0
.bss 78856 78856 0 0.0
.data 3268 3268 0 0.0
.rodata 85715 85715 0 0.0
.text 591768 591760 -8 -0.0
shell LP_CC2652R7 (read only) 674110 674110 0 0.0
(read/write) 160732 160732 0 0.0
.bss 83320 83320 0 0.0
.data 3300 3300 0 0.0
.rodata 85510 85510 0 0.0
.text 588280 588280 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 604658 604658 0 0.0
(read/write) 204172 204172 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197584 197584 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 960708 960708 0 0.0
.debug_aranges 101288 101288 0 0.0
.debug_frame 341932 341932 0 0.0
.debug_info 1953006 19530065 -1 -0.0
.debug_line 2668863 2668863 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1487820 1487820 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94417 94417 0 0.0
.debug_str 3102436 3102436 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104498 104498 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483187 483187 0 0.0
.symtab 287536 287536 0 0.0
.text 498036 498036 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 523987 523987 0 0.0
.app_xip_area 416781 416781 0 0.0
.bss 62192 62192 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 528667 528667 0 0.0
.app_xip_area 416165 416165 0 0.0
.bss 67480 67480 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566187 566179 -8 -0.0
.app_xip_area 459733 459725 -8 -0.0
.bss 61480 61480 0 0.0
.data 668 668 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 530547 530555 8 0.0
.app_xip_area 421541 421549 8 0.0
.bss 63960 63960 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w contact k32w0+release (read only) 584420 584420 0 0.0
(read/write) 90100 90100 0 0.0
.bss 66104 66104 0 0.0
.data 2168 2168 0 0.0
.text 583884 583884 0 0.0
light k32w0+release (read only) 583220 583220 0 0.0
(read/write) 89748 89748 0 0.0
.bss 65768 65768 0 0.0
.data 2156 2156 0 0.0
.text 582684 582684 0 0.0
lock k32w0+release (read only) 555708 555708 0 0.0
(read/write) 87556 87556 0 0.0
.bss 63632 63632 0 0.0
.data 2100 2100 0 0.0
.text 555172 555172 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12215004 12215004 0 0.0
(read/write) 746296 746296 0 0.0
.bss 34408 34408 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 688016 688016 0 0.0
.dynamic 560 560 0 0.0
.got 15672 15672 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 568896 568896 0 0.0
.text 9874772 9874772 0 0.0
thermostat-no-ble arm64 (read only) 2527668 2527668 0 0.0
(read/write) 145960 145960 0 0.0
.bss 56392 56392 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 78248 78248 0 0.0
.dynamic 560 560 0 0.0
.got 5456 5456 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 130184 130184 0 0.0
.text 2132848 2132848 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1178396 1178396 0 0.0
bss 155601 155601 0 0.0
rodata 133180 133180 0 0.0
text 808892 808896 4 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1438216 1438216 0 0.0
bss 135341 135341 0 0.0
rodata 229112 229112 0 0.0
text 779720 779720 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1123648 1123648 0 0.0
bss 154757 154757 0 0.0
rodata 109984 109984 0 0.0
text 778180 778180 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 840632 840632 0 0.0
(read/write) 1708540 1708540 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 190156 190156 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2552 2552 0 0.0
.debug_abbrev 1298180 1298180 0 0.0
.debug_aranges 128696 128696 0 0.0
.debug_frame 426724 426724 0 0.0
.debug_info 27087589 27087588 -1 -0.0
.debug_line 3772037 3772037 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2020969 2020969 0 0.0
.debug_rnglists 128379 128379 0 0.0
.debug_str 3615494 3615494 0 0.0
.heap 840632 840632 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 720542 720542 0 0.0
.symtab 468192 468192 0 0.0
.text 1507444 1507444 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841432 841432 0 0.0
(read/write) 1648460 1648460 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189356 189356 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2552 2552 0 0.0
.debug_abbrev 1283196 1283196 0 0.0
.debug_aranges 127840 127840 0 0.0
.debug_frame 428780 428780 0 0.0
.debug_info 26601226 26601226 0 0.0
.debug_line 3779210 3779210 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2010608 2010608 0 0.0
.debug_rnglists 127264 127264 0 0.0
.debug_str 3601962 3601962 0 0.0
.heap 841432 841432 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 674969 674969 0 0.0
.symtab 452048 452048 0 0.0
.text 1448164 1448164 0 0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 849728 849728 0 0.0
(read/write) 1570308 1570308 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 181228 181228 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2384 2384 0 0.0
.debug_abbrev 1114830 1114830 0 0.0
.debug_aranges 117960 117960 0 0.0
.debug_frame 391912 391912 0 0.0
.debug_info 22155370 22155372 2 0.0
.debug_line 3342184 3342184 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 1842746 1842746 0 0.0
.debug_rnglists 116869 116869 0 0.0
.debug_str 3408390 3408390 0 0.0
.heap 849728 849728 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 591022 591022 0 0.0
.symtab 414496 414496 0 0.0
.text 1378308 1378308 0 0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 821936 821936 0 0.0
(read/write) 1626804 1626804 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 209012 209012 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1113894 1113894 0 0.0
.debug_aranges 118472 118472 0 0.0
.debug_frame 394032 394032 0 0.0
.debug_info 22333534 22333533 -1 -0.0
.debug_line 3338591 3338591 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 1856140 1856140 0 0.0
.debug_rnglists 117331 117331 0 0.0
.debug_str 3423372 3423372 0 0.0
.heap 821936 821936 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 595023 595023 0 0.0
.symtab 416800 416800 0 0.0
.text 1407012 1407012 0 0.0
.zero.table 8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1168080 1168080 0 0.0
.bss 99632 99632 0 0.0
.data 856 856 0 0.0
.text 615180 615180 0 0.0
lock-app qpg6105+debug (read/write) 1137456 1137456 0 0.0
.bss 94784 94784 0 0.0
.data 852 852 0 0.0
.text 584552 584552 0 0.0

@woody-apple woody-apple added this to the No Target Milestone milestone Nov 27, 2023
@chshu chshu merged commit 28733f1 into project-chip:v1.1-branch Mar 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
esp32 platform
Projects
None yet
Milestone
No Target Milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wqx6 @chshu @woody-apple