-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Subscription resumption after timeout #27956
Merged
mergify
merged 5 commits into
project-chip:master
from
jtung-apple:jtung/sub-resumption-network-outage-resumption
Jul 22, 2023
Merged
[ICD] Subscription resumption after timeout #27956
mergify
merged 5 commits into
project-chip:master
from
jtung-apple:jtung/sub-resumption-network-outage-resumption
Jul 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
kcoppock
July 14, 2023 05:24
…ddressed review comments
jtung-apple
force-pushed
the
jtung/sub-resumption-network-outage-resumption
branch
from
July 19, 2023 20:02
0ab02f4
to
d8571c4
Compare
andy31415
reviewed
Jul 20, 2023
andy31415
reviewed
Jul 20, 2023
andy31415
reviewed
Jul 20, 2023
…ptions by default
woody-apple
approved these changes
Jul 20, 2023
bzbarsky-apple
approved these changes
Jul 20, 2023
pullapprove
bot
requested review from
aronrosenberg,
mlepage-google and
tehampson
July 21, 2023 11:19
andy31415
reviewed
Jul 21, 2023
andy31415
reviewed
Jul 21, 2023
andy31415
approved these changes
Jul 21, 2023
jtung-apple
force-pushed
the
jtung/sub-resumption-network-outage-resumption
branch
3 times, most recently
from
July 22, 2023 04:08
f915189
to
4d137d7
Compare
jtung-apple
force-pushed
the
jtung/sub-resumption-network-outage-resumption
branch
from
July 22, 2023 15:22
4d137d7
to
d663470
Compare
PR #27956: Size comparison from c66f2a0 to d663470 Increases (32 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, linux, psoc6, telink)
Decreases (9 builds for bl702, bl702l, cc32xx, nrfconnect, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
doru91
added a commit
to NXP/matter
that referenced
this pull request
Aug 4, 2023
Introduced in Core SDK by project-chip#27956 Signed-off-by: Doru Gucea <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a long-overdue extension to subscription resumption in the case where a timeout happens. Specifically, network/power outage can cause subscriptions to be lost. This patch introduces a compiler feature flag
chip_subscription_timeout_resumption
to enable subscription resumption in the case when timeout happens.The default retry intervals in
CHIPConfig.h
are meant to be long - starts at 5 minutes minimum and with fibonacci backoff up to 6 hours, which should be negligible compared to general report max intervals. The intention here is to have a default recovery mechanism that is low power usage.This implementation is optional, and is only enabled if on darwin/linux by default for CI, and platforms that wish to support this should make use of the compile flag as needed.