[DISHM]-Initial add of yaml test scripts for dishwasher mode cluster #27946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abpoth
commented
Jul 13, 2023
•
abpoth
commented
|
|
|
PR #27946: Size comparison from d9a6f2e to ad3b8a9 Increases (1 build for cyw30739)
Decreases (5 builds for bl602, bl702l, cyw30739, psoc6)
Full report (29 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
|
PR #27946: Size comparison from 5edf049 to a285535 Increases (11 builds for cyw30739, esp32, linux, qpg, telink)
Decreases (14 builds for cc32xx, cyw30739, esp32, k32w, linux, psoc6, telink)
Full report (49 builds for cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
PR #27946: Size comparison from 7a39e50 to 1eb8df7 Decreases (3 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
|
PR #27946: Size comparison from 6268fbb to bcfd6c8 Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Comment on lines
104
to
105
| "4. TH reads optional attribute (DISHM.S.F00(DEPONOFF)) in | ||
| AttributeList" |
There was a problem hiding this comment.
I don't see this in the test plan... Did it get changed after the last update to this PR?
Comment on lines
115
to
116
| "4. TH reads optional attribute (DISHM.S.F00(DEPONOFF)) in | ||
| AttributeList" |
There was a problem hiding this comment.
Again, don't see this in the test plan.
|
|
||
| asserts.assert_greater_equal(len(supported_modes), 2, "SupportedModes must have at least two entries!") | ||
|
|
||
| supported_modes_dut = [m.mode for m in supported_modes] |
There was a problem hiding this comment.
Test plan says to verify that self.modeFail is in supported_modes_dut, no? Though it says that before it sets the value of supported_modes_dut...
There was a problem hiding this comment.
The test plan for this one says "REMOVED". Should we still have this?
(I did review it, and the code matches the claimed-removed test plan.)
There was a problem hiding this comment.
Likewise, says "REMOVED".
| self.print_step(5, "Read CurrentMode attribute") | ||
|
|
||
| old_current_mode_dut = await self.read_mode_attribute_expect_success(endpoint=self.endpoint, attribute=attributes.CurrentMode) | ||
| self.default_controller.ExpireSessions(self.dut_node_id) |
There was a problem hiding this comment.
Why is this ExpireSessions here? I don't see it in the test plan.... If the idea is to save time or avoid errors, when the device is power-cycled, shouldn't this be at the point where the power-cycle happens?
There was a problem hiding this comment.
This one also seems to be removed?
That said, I reviewed this, and it looks good modulo the documented issue from https://github.com/CHIP-Specifications/chip-test-plans/issues/3478
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
|
PR #27946: Size comparison from 6268fbb to 8921f91 Increases (56 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
Decreases (23 builds for cyw30739, efr32, esp32, linux, nrfconnect, telink)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
|
PR not updated in 1 year, has merge conflicts, CI failures and changes requested tags. Closing as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.