-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrfconnect] bypass support for IPv4 #27851
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
July 10, 2023 08:26
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
July 10, 2023 08:26
PR #27851: Size comparison from 08af5fa to b54920b Increases (4 builds for bl602, bl702l, cc32xx, qpg)
Full report (14 builds for bl602, bl702, bl702l, cc32xx, k32w, linux, mbed, qpg)
|
markaj-nordic
force-pushed
the
ncs_disable_ipv4
branch
from
July 10, 2023 09:13
b54920b
to
bd63c1a
Compare
markaj-nordic
force-pushed
the
ncs_disable_ipv4
branch
from
July 10, 2023 09:16
bd63c1a
to
1348718
Compare
Damian-Nordic
approved these changes
Jul 10, 2023
PR #27851: Size comparison from 08af5fa to 1348718 Increases (12 builds for bl602, cyw30739, efr32, psoc6, qpg, telink)
Decreases (8 builds for bl602, efr32, esp32, psoc6, telink)
Full report (69 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
This change allows to build nrfconnect SDK samples with Matter over IPv6 but IPv4 still available for third party development within the same application. Signed-off-by: Marcin Kajor <[email protected]>
markaj-nordic
force-pushed
the
ncs_disable_ipv4
branch
from
July 10, 2023 11:14
1348718
to
da8d3f9
Compare
PR #27851: Size comparison from 08af5fa to da8d3f9 Increases (14 builds for bl602, cc32xx, cyw30739, efr32, esp32, psoc6, qpg, telink)
Decreases (9 builds for bl602, efr32, nrfconnect, telink)
Full report (69 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jul 10, 2023
woody-apple
pushed a commit
to woody-apple/connectedhomeip
that referenced
this pull request
Jul 12, 2023
This change allows to build nrfconnect SDK samples with Matter over IPv6 but IPv4 still available for third party development within the same application. Signed-off-by: Marcin Kajor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to build nrfconnect SDK samples with Matter over IPv6 but IPv4 still available for third party development within the same application.