-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/dishwasher alarm impl #27748
Merged
mergify
merged 81 commits into
project-chip:master
from
fengdx4:feature/dishwasher_alarm_impl
Jul 24, 2023
Merged
Feature/dishwasher alarm impl #27748
mergify
merged 81 commits into
project-chip:master
from
fengdx4:feature/dishwasher_alarm_impl
Jul 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harimau-qirex,
harsha-rajendran and
hawk248
July 7, 2023 08:34
…er.h Co-authored-by: Boris Zbarsky <[email protected]>
…er.cpp Co-authored-by: Boris Zbarsky <[email protected]>
…ngdx4/connectedhomeip into feature/dishwasher_alarm_impl
bzbarsky-apple
approved these changes
Jul 21, 2023
src/app/clusters/dishwasher-alarm-server/dishwasher-alarm-server.h
Outdated
Show resolved
Hide resolved
…er.h Co-authored-by: Boris Zbarsky <[email protected]>
rbultman
approved these changes
Jul 21, 2023
marktrayer
approved these changes
Jul 21, 2023
mideayanghui
approved these changes
Jul 24, 2023
PR #27748: Size comparison from c1ec2d7 to 3d0ec9d Increases above 0.2%:
Increases (27 builds for bl602, bl702, bl702l, cc32xx, esp32, k32w, linux, nrfconnect, psoc6, telink)
Decreases (9 builds for bl602, bl702, psoc6, qpg, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
appliances
Stuff related to appliance types and clusters
dishwashers
examples
review - approved
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dishwasher alarm cluster implementation