-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve chip-tool help for "synthetic" clusters. #27665
Merged
mergify
merged 3 commits into
project-chip:master
from
bzbarsky-apple:chip-tool-better-help
Jul 11, 2023
Merged
Improve chip-tool help for "synthetic" clusters. #27665
mergify
merged 3 commits into
project-chip:master
from
bzbarsky-apple:chip-tool-better-help
Jul 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple and
lazarkov
July 6, 2023 17:07
bzbarsky-apple
commented
Jul 6, 2023
PR #27665: Size comparison from 38d627a to 256d7e1 Increases (8 builds for bl702, linux, mbed, nrfconnect, psoc6)
Decreases (6 builds for bl602, bl702, cc32xx, cyw30739, linux)
Full report (42 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
1. Makes it clear which things are actual clusters and which are command sets. 2. Makes sure all command sets have overall help text that describes what the commands in the set do. 3. Adds some help text to some specific commands.
bzbarsky-apple
force-pushed
the
chip-tool-better-help
branch
from
July 6, 2023 18:21
256d7e1
to
474344c
Compare
PR #27665: Size comparison from ba5c7c5 to 474344c Increases (14 builds for bl602, bl702, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Decreases (15 builds for bl602, cyw30739, esp32, linux, nrfconnect, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Jul 6, 2023
tcarmelveilleux
approved these changes
Jul 6, 2023
PR #27665: Size comparison from ba5c7c5 to b29b9af Increases (14 builds for bl602, bl702, esp32, linux, nrfconnect, psoc6, telink)
Decreases (8 builds for cyw30739, linux, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Jul 7, 2023
pullapprove
bot
requested review from
hicklin,
mhazley,
p0fi,
plauric,
tima-q and
tobiasgraf
July 7, 2023 21:36
vivien-apple
approved these changes
Jul 11, 2023
vivien-apple
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example output:
I put the command sets second because that way they are more visible if you just run chip-tool, unless you redirect to a pager...