-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Account for the retry delay booster in unit test" #27532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
June 28, 2023 20:57
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
xylophone21,
younghak-hwang and
yufengwangca
June 28, 2023 20:58
PR #27532: Size comparison from 96731f2 to 1523fbc Increases (8 builds for bl702, bl702l, nrfconnect, telink)
Decreases (10 builds for bl602, nrfconnect, psoc6, telink)
Full report (46 builds for bl602, bl702, bl702l, cyw30739, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
This reverts commit 6db0276.
woody-apple
force-pushed
the
revert-27519-booster
branch
from
June 29, 2023 01:33
1523fbc
to
66f9b20
Compare
PR #27532: Size comparison from d72d756 to 66f9b20 Increases (8 builds for bl602, bl702, nrfconnect, telink)
Decreases (10 builds for bl702l, telink)
Full report (25 builds for bl602, bl702, bl702l, mbed, nrfconnect, telink)
|
@woody-apple Why do we want to revert this? PR description should say. |
That was a speculation that this commit has caused Darwin tests start to fail in an excessive rate. |
pullapprove
bot
requested review from
hicklin,
mhazley,
p0fi,
plauric,
tima-q and
tobiasgraf
July 10, 2023 21:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #27519