-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update availability annotations for alarm clusters. #27487
Merged
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:alarm-availability
Jun 27, 2023
Merged
Update availability annotations for alarm clusters. #27487
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:alarm-availability
Jun 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bzbarsky-apple
commented
Jun 26, 2023
- Adds Supported attribute to RefrigeratorAlarm.
- Marks DishwasherAlarm as provisional for now, until APIs stabilize.
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
June 26, 2023 18:13
pullapprove
bot
requested review from
LuDuda,
mrjerryjohns,
msandstedt,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
June 26, 2023 18:13
woody-apple
approved these changes
Jun 26, 2023
PR #27487: Size comparison from 31b0571 to f145f7e Increases (4 builds for bl702, cc32xx, esp32, telink)
Decreases (8 builds for esp32, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
1) Adds Supported attribute to RefrigeratorAlarm. 2) Marks DishwasherAlarm as provisional for now, until APIs stabilize.
bzbarsky-apple
force-pushed
the
alarm-availability
branch
from
June 26, 2023 21:34
f145f7e
to
d115ce3
Compare
PR #27487: Size comparison from dbf5f41 to d115ce3 Increases (8 builds for bl602, bl702, cc32xx, qpg, telink)
Decreases (3 builds for esp32, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.