Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timesync: Remove non-spec compliant step #27458

Merged

Conversation

cecille
Copy link
Contributor

@cecille cecille commented Jun 25, 2023

This section of test steps is incorrect because the list always needs to have a 0 entry with a validAt time of 0. Removed from the test plans in https://github.com/CHIP-Specifications/chip-test-plans/pull/2934

@github-actions
Copy link

github-actions bot commented Jun 25, 2023

PR #27458: Size comparison from 7806dd1 to 9ebbab4

Increases (8 builds for bl602, bl702, psoc6, qpg, telink)
platform target config section 7806dd1 9ebbab4 change % change
bl602 lighting-app bl602+rpc (read/write) 1414178 1414186 8 0.0
.text 1083056 1083058 2 0.0
bl702 lighting-app bl702 (read/write) 1175207 1175211 4 0.0
.debug_info 41615360 41615361 1 0.0
.text 946052 946054 2 0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 23110486 23110487 1 0.0
qpg lock-app qpg6105+debug (read/write) 1129984 1129992 8 0.0
.text 576828 576836 8 0.0
telink all-clusters-app tlsr9518adk80d text 710454 710456 2 0.0
light-switch-app tlsr9518adk80d (read/write) 877956 877964 8 0.0
text 600628 600632 4 0.0
lock-app tlsr9518adk80d text 614670 614674 4 0.0
ota-requestor-app tlsr9518adk80d text 607848 607850 2 0.0
Decreases (10 builds for bl702, nrfconnect, psoc6, telink)
platform target config section 7806dd1 9ebbab4 change % change
bl702 lighting-app bl702+rpc (read/write) 1273323 1273319 -4 -0.0
.debug_info 46799756 46799755 -1 -0.0
.text 1019934 1019932 -2 -0.0
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp text 753748 753744 -4 -0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 22806394 22806393 -1 -0.0
telink all-clusters-minimal-app tlsr9518adk80d text 667738 667736 -2 -0.0
bridge-app tlsr9518adk80d (read/write) 929940 929932 -8 -0.0
text 642834 642832 -2 -0.0
contact-sensor-app tlsr9518adk80d text 586004 586002 -2 -0.0
pump-controller-app tlsr9518adk80d text 582110 582108 -2 -0.0
temperature-measurement-app tlsr9518adk80d text 577740 577738 -2 -0.0
thermostat tlsr9518adk80d text 617160 617158 -2 -0.0
window-covering tlsr9518adk80d text 612082 612078 -4 -0.0
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 7806dd1 9ebbab4 change % change
bl602 lighting-app bl602 (read/write) 1366494 1366494 0 0.0
.bss 83942 83942 0 0.0
.data 9608 9608 0 0.0
.text 1050918 1050918 0 0.0
bl602+rpc (read/write) 1414178 1414186 8 0.0
.bss 91990 91990 0 0.0
.data 10008 10008 0 0.0
.text 1083056 1083058 2 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1175207 1175211 4 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 77781 77781 0 0.0
.bss_psram 24656 24656 0 0.0
.comment 48 48 0 0.0
.data 3592 3592 0 0.0
.debug_abbrev 1545845 1545845 0 0.0
.debug_aranges 149992 149992 0 0.0
.debug_frame 552096 552096 0 0.0
.debug_info 41615360 41615361 1 0.0
.debug_line 5583608 5583608 0 0.0
.debug_loc 3801252 3801252 0 0.0
.debug_ranges 395272 395272 0 0.0
.debug_str 4351073 4351073 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 105408 105408 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 582415 582415 0 0.0
.symtab 174192 174192 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
946052 946054 2 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1273323 1273319 -4 -0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 85829 85829 0 0.0
.bss_psram 25072 25072 0 0.0
.comment 48 48 0 0.0
.data 4144 4144 0 0.0
.debug_abbrev 1711094 1711094 0 0.0
.debug_aranges 158464 158464 0 0.0
.debug_frame 580728 580728 0 0.0
.debug_info 46799756 46799755 -1 -0.0
.debug_line 6009916 6009916 0 0.0
.debug_loc 4006538 4006538 0 0.0
.debug_ranges 420944 420944 0 0.0
.debug_str 4779701 4779701 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 120048 120048 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 644984 644984 0 0.0
.symtab 192992 192992 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1019934 1019932 -2 -0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 607482 607482 0 0.0
(read/write) 204172 204172 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197584 197584 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 948407 948407 0 0.0
.debug_aranges 119144 119144 0 0.0
.debug_frame 406896 406896 0 0.0
.debug_info 19925353 19925353 0 0.0
.debug_line 2874114 2874114 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1729321 1729321 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 107681 107681 0 0.0
.debug_str 3792650 3792650 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104650 104650 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 484980 484980 0 0.0
.symtab 288160 288160 0 0.0
.text 500712 500712 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 545239 545239 0 0.0
.app_xip_area 437649 437649 0 0.0
.bss 62568 62568 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 530287 530287 0 0.0
.app_xip_area 417777 417777 0 0.0
.bss 67480 67480 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 567983 567983 0 0.0
.app_xip_area 461537 461537 0 0.0
.bss 61472 61472 0 0.0
.data 668 668 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 532087 532087 0 0.0
.app_xip_area 423073 423073 0 0.0
.bss 63960 63960 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 997752 997752 0 0.0
.bss 182064 182064 0 0.0
.data 2148 2148 0 0.0
.text 813516 813516 0 0.0
BRD4187C (read/write) 1026820 1026820 0 0.0
.bss 161788 161788 0 0.0
.data 2792 2792 0 0.0
.text 862220 862220 0 0.0
lock-app BRD4161A+wf200 (read/write) 1075920 1075920 0 0.0
.bss 176120 176120 0 0.0
.data 2152 2152 0 0.0
.text 897628 897628 0 0.0
window-app BRD4187C (read/write) 1097332 1097332 0 0.0
.bss 144740 144740 0 0.0
.data 2688 2688 0 0.0
.text 949884 949884 0 0.0
esp32 all-clusters-app c3devkit (read only) 1078004 1078004 0 0.0
(read/write) 1585016 1585016 0 0.0
.dram0.bss 75616 75616 0 0.0
.dram0.data 13940 13940 0 0.0
.flash.rodata 216320 216320 0 0.0
.flash.text 1078004 1078004 0 0.0
.iram0.text 76740 76740 0 0.0
m5stack (read only) 1125707 1125707 0 0.0
(read/write) 495454 495454 0 0.0
.dram0.bss 81088 81088 0 0.0
.dram0.data 34304 34304 0 0.0
.flash.rodata 244912 244912 0 0.0
.flash.text 1120323 1120323 0 0.0
.iram0.text 126055 126055 0 0.0
k32w contact k32w0+release (read only) 586132 586132 0 0.0
(read/write) 90104 90104 0 0.0
.bss 66108 66108 0 0.0
.data 2168 2168 0 0.0
.text 585596 585596 0 0.0
light k32w0+release (read only) 584820 584820 0 0.0
(read/write) 89752 89752 0 0.0
.bss 65772 65772 0 0.0
.data 2156 2156 0 0.0
.text 584284 584284 0 0.0
lock k32w0+release (read only) 557404 557404 0 0.0
(read/write) 87560 87560 0 0.0
.bss 63636 63636 0 0.0
.data 2100 2100 0 0.0
.text 556868 556868 0 0.0
linux chip-tool-ipv6only arm64 (read only) 17376048 17376048 0 0.0
(read/write) 907336 907336 0 0.0
.bss 102936 102936 0 0.0
.data 4448 4448 0 0.0
.data.rel.ro 771112 771112 0 0.0
.dynamic 560 560 0 0.0
.got 23352 23352 0 0.0
.init 24 24 0 0.0
.init_array 240 240 0 0.0
.rodata 686616 686616 0 0.0
.text 14707732 14707732 0 0.0
thermostat-no-ble arm64 (read only) 2610108 2610108 0 0.0
(read/write) 143128 143128 0 0.0
.bss 52376 52376 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 560 560 0 0.0
.got 5512 5512 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 129648 129648 0 0.0
.text 2214644 2214644 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2499088 2499088 0 0.0
.bss 216312 216312 0 0.0
.data 5144 5144 0 0.0
.text 1461772 1461772 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1213484 1213484 0 0.0
bss 155045 155045 0 0.0
rodata 138144 138144 0 0.0
text 841152 841152 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1316260 1316260 0 0.0
bss 138371 138371 0 0.0
rodata 133432 133432 0 0.0
text 753748 753744 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1151148 1151148 0 0.0
bss 153541 153541 0 0.0
rodata 111408 111408 0 0.0
text 807160 807160 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841680 841680 0 0.0
(read/write) 1732324 1732324 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189092 189092 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2568 2568 0 0.0
.debug_abbrev 1299084 1299084 0 0.0
.debug_aranges 149288 149288 0 0.0
.debug_frame 499872 499872 0 0.0
.debug_info 29011002 29011002 0 0.0
.debug_line 4040260 4040260 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2310736 2310736 0 0.0
.debug_rnglists 144654 144654 0 0.0
.debug_str 4364474 4364474 0 0.0
.heap 841680 841680 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 754286 754286 0 0.0
.symtab 480528 480528 0 0.0
.text 1532276 1532276 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 843160 843160 0 0.0
(read/write) 1664172 1664172 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187620 187620 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2560 2560 0 0.0
.debug_abbrev 1282129 1282129 0 0.0
.debug_aranges 147904 147904 0 0.0
.debug_frame 500424 500424 0 0.0
.debug_info 28313614 28313614 0 0.0
.debug_line 4035825 4035825 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2294026 2294026 0 0.0
.debug_rnglists 143002 143002 0 0.0
.debug_str 4344747 4344747 0 0.0
.heap 843160 843160 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 703099 703099 0 0.0
.symtab 461632 461632 0 0.0
.text 1465604 1465604 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849352 849352 0 0.0
(read/write) 1596980 1596980 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 181596 181596 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1118963 1118963 0 0.0
.debug_aranges 138264 138264 0 0.0
.debug_frame 464388 464388 0 0.0
.debug_info 23110486 23110487 1 0.0
.debug_line 3607869 3607869 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 2135235 2135235 0 0.0
.debug_rnglists 133024 133024 0 0.0
.debug_str 4158766 4158766 0 0.0
.heap 849352 849352 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 626743 626743 0 0.0
.symtab 427200 427200 0 0.0
.text 1404604 1404604 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 821960 821960 0 0.0
(read/write) 1627700 1627700 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208988 208988 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1101242 1101242 0 0.0
.debug_aranges 136336 136336 0 0.0
.debug_frame 457592 457592 0 0.0
.debug_info 22806394 22806393 -1 -0.0
.debug_line 3542321 3542321 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 2103123 2103123 0 0.0
.debug_rnglists 130518 130518 0 0.0
.debug_str 4113679 4113679 0 0.0
.heap 821960 821960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 596881 596881 0 0.0
.symtab 417408 417408 0 0.0
.text 1407932 1407932 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1172376 1172376 0 0.0
.bss 99960 99960 0 0.0
.data 788 788 0 0.0
.text 619216 619216 0 0.0
lock-app qpg6105+debug (read/write) 1129984 1129992 8 0.0
.bss 94816 94816 0 0.0
.data 792 792 0 0.0
.text 576828 576836 8 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1037852 1037852 0 0.0
bss 97960 97960 0 0.0
text 710454 710456 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 964436 964436 0 0.0
bss 96340 96340 0 0.0
text 667738 667736 -2 -0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 929940 929932 -8 -0.0
bss 100312 100312 0 0.0
text 642834 642832 -2 -0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 861640 861640 0 0.0
bss 89972 89972 0 0.0
text 586004 586002 -2 -0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 877956 877964 8 0.0
bss 90140 90140 0 0.0
text 600628 600632 4 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 968524 968524 0 0.0
bss 98712 98712 0 0.0
text 681724 681724 0 0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 979904 979904 0 0.0
bss 102960 102960 0 0.0
text 689242 689242 0 0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1038016 1038016 0 0.0
bss 100268 100268 0 0.0
text 726614 726614 0 0.0
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1069372 1069372 0 0.0
bss 111352 111352 0 0.0
text 746760 746760 0 0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 916752 916752 0 0.0
bss 90636 90636 0 0.0
text 614670 614674 4 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 884240 884240 0 0.0
bss 91248 91248 0 0.0
text 607848 607850 2 0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 867240 867240 0 0.0
bss 90104 90104 0 0.0
text 591764 591764 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 854260 854260 0 0.0
bss 89904 89904 0 0.0
text 582110 582108 -2 -0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 850416 850416 0 0.0
bss 89812 89812 0 0.0
text 577740 577738 -2 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 896328 896328 0 0.0
bss 90348 90348 0 0.0
text 617160 617158 -2 -0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 891708 891708 0 0.0
bss 90640 90640 0 0.0
text 612082 612078 -4 -0.0

@mergify mergify bot merged commit 1c694cf into project-chip:master Jun 27, 2023
@cecille cecille deleted the timesync_tests_tz_remove_incorrect_steps branch July 10, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants