-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python tests: fix compare_time, add test #27457
Merged
mergify
merged 2 commits into
project-chip:master
from
cecille:python_tests_fix_compare_time
Jun 26, 2023
Merged
Python tests: fix compare_time, add test #27457
mergify
merged 2 commits into
project-chip:master
from
cecille:python_tests_fix_compare_time
Jun 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #27457: Size comparison from 7806dd1 to d635b65 Increases (9 builds for bl702, qpg, telink)
Decreases (11 builds for esp32, k32w, nrfconnect, psoc6, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
approved these changes
Jun 25, 2023
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
June 26, 2023 11:14
pullapprove
bot
requested review from
msandstedt,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
younghak-hwang
June 26, 2023 11:14
PR #27457: Size comparison from 7806dd1 to ac28c9e Increases (14 builds for bl702, cc32xx, linux, psoc6, qpg, telink)
Decreases (11 builds for bl602, bl702, esp32, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Jun 26, 2023
woody-apple
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare time function is incorrect because "microseconds" ONLY includes the fractional seconds. total_seconds() is the right thing here - it's a float and includes the entire time, including fractional seconds, so it can be directly converted to microseconds.
Also add a test.