Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing iMX Build #27402

Merged
merged 5 commits into from
Jun 22, 2023
Merged

Fixing iMX Build #27402

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
34b7b2b
Testing this
woody-apple Jun 21, 2023
dd95f31
Adding imx back
woody-apple Jun 21, 2023
a2b3523
Fixing dockerfile to remove just .debug
woody-apple Jun 22, 2023
c432400
can't relibable build yet
woody-apple Jun 22, 2023
3248e64
Putting this comment back
woody-apple Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/workflows/docker_img.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,6 @@ jobs:
- "-esp32"
- "-esp32-qemu"
- "-infineon"
# NOTE: imx image requires too much space for GitHub-hosted runners. It fails with:
woody-apple marked this conversation as resolved.
Show resolved Hide resolved
# ```
# ....
# ApplyLayer exit status 1 stdout: stderr: write /opt/fsl-imx-xwayland/5.15-kirkstone/sysroots/armv8a-poky-linux/opt/ltp/testcases/bin/fanotify15: no space left on device
# ```
# - "-imx"
- "-k32w"
- "-mbed-os"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/examples-linux-imx.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
if: github.actor != 'restyled-io[bot]'

container:
image: connectedhomeip/chip-build-imx:0.7.3
image: connectedhomeip/chip-build-imx:0.7.19.1

steps:
- uses: Wandalen/[email protected]
Expand Down
5 changes: 5 additions & 0 deletions integrations/docker/images/chip-build-imx/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ RUN set -x \
&& ./fsl-imx-xwayland-glibc-x86_64-imx-image-multimedia-armv8a-imx8mmevk-toolchain-5.15-kirkstone.sh -y \
&& rm -rf fsl-imx-xwayland-glibc-x86_64-imx-image-multimedia-armv8a-imx8mmevk-toolchain-5.15-kirkstone.sh \
&& : # last line
RUN set -x \
&& cd /opt/fsl-imx-xwayland \
# && find . -iname debug -exec rm -rf "{}" + || true \
&& find . -iname ".debug" -exec rm -rf "{}" + || true \
&& : # last line

FROM connectedhomeip/chip-build:${VERSION}

Expand Down
2 changes: 1 addition & 1 deletion integrations/docker/images/chip-build/version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.7.18 Version bump reason: vscode ZEPHYR SDK env path update
0.7.19.1 Version bump reason: Reducing size of imx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just 0.7.19 or 0.7.20?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To not conflict with another going on from Andrei

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the future I would vote for 3 digit only, to make our regex history easier. Conflicts are ok and intended.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 0.7.20?