-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missed adding retries to 4 spots, spotted failures #27397
Merged
woody-apple
merged 7 commits into
project-chip:master
from
woody-apple:buildjet-timeouts
Jun 21, 2023
Merged
Missed adding retries to 4 spots, spotted failures #27397
woody-apple
merged 7 commits into
project-chip:master
from
woody-apple:buildjet-timeouts
Jun 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woody-apple
added
build issue
hotfix
urgent fix needed, can bypass review
fast track
and removed
github
workflows
labels
Jun 21, 2023
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha and
emargolis
June 21, 2023 19:02
pullapprove
bot
requested review from
kcoppock,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
xylophone21 and
younghak-hwang
June 21, 2023 19:02
pullapprove
bot
added
review - pending
and removed
build issue
hotfix
urgent fix needed, can bypass review
fast track
labels
Jun 21, 2023
PR #27397: Size comparison from 3706e06 to 0ca423f Increases (7 builds for esp32, psoc6, telink)
Decreases (15 builds for bl602, cc32xx, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Forcing this in, affected CI passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found 4 spots where things were still failing. Adding retries to these, to have the same behavior of the rest. (I wish we didn't have to copy paste in workflows...)