-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[matter_yamltests] Add saveDataVersionAs supports #27324
Merged
mergify
merged 1 commit into
project-chip:master
from
vivien-apple:YamlTests_SaveDataVersionAs
Jun 20, 2023
Merged
[matter_yamltests] Add saveDataVersionAs supports #27324
mergify
merged 1 commit into
project-chip:master
from
vivien-apple:YamlTests_SaveDataVersionAs
Jun 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kcoppock
June 19, 2023 14:11
pullapprove
bot
requested review from
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
June 19, 2023 14:11
examples/chip-tool/py_matter_chip_tool_adapter/matter_chip_tool_adapter/encoder.py
Show resolved
Hide resolved
tcarmelveilleux
approved these changes
Jun 19, 2023
PR #27324: Size comparison from 4b056e5 to 0251ede Increases (13 builds for bl702, esp32, nrfconnect, psoc6, qpg, telink)
Decreases (8 builds for cyw30739, psoc6, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Jun 20, 2023
vivien-apple
force-pushed
the
YamlTests_SaveDataVersionAs
branch
from
June 20, 2023 08:31
0251ede
to
7527ba8
Compare
PR #27324: Size comparison from 9a5b909 to 7527ba8 Increases (8 builds for bl702, psoc6, qpg, telink)
Decreases (8 builds for bl702, cc32xx, esp32, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR make it possible to save the data version from a request and use the saved value into an other test.