-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hotfix] Fix merge error in matter_testing_support.py #27293
Merged
andy31415
merged 1 commit into
project-chip:master
from
tcarmelveilleux:quick-fix-printing
Jun 16, 2023
Merged
[hotfix] Fix merge error in matter_testing_support.py #27293
andy31415
merged 1 commit into
project-chip:master
from
tcarmelveilleux:quick-fix-printing
Jun 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Silent stacktraces were red herrings because step printing got broken by a bad merge. Issue project-chip#27287
tcarmelveilleux
added
hotfix
urgent fix needed, can bypass review
trivial
This issue should be trivial to fix
labels
Jun 16, 2023
andy31415
approved these changes
Jun 16, 2023
cecille
approved these changes
Jun 16, 2023
PR #27293: Size comparison from 5ed31da to 3796a4c Increases (11 builds for bl602, esp32, nrfconnect, psoc6, qpg, telink)
Decreases (9 builds for cc32xx, nrfconnect, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #27287