-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't expose robotic vacuum operational state in Darwin API yet. #27271
Merged
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:robotic-vacuum-darwin-api
Jun 20, 2023
Merged
Don't expose robotic vacuum operational state in Darwin API yet. #27271
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:robotic-vacuum-darwin-api
Jun 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #27271: Size comparison from 82438f5 to db9105a Increases (7 builds for bl602, psoc6, telink)
Decreases (12 builds for cyw30739, esp32, nrfconnect, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
robotic-vacuum-darwin-api
branch
from
June 16, 2023 02:33
db9105a
to
c76928d
Compare
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no and
ksperling-apple
June 16, 2023 02:34
pullapprove
bot
requested review from
msandstedt,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
June 16, 2023 02:34
PR #27271: Size comparison from 83f7a2f to c76928d Increases (6 builds for cyw30739, esp32, psoc6, telink)
Decreases (12 builds for bl702, esp32, nrfconnect, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
robotic-vacuum-darwin-api
branch
2 times, most recently
from
June 16, 2023 15:05
f17e26b
to
aee4371
Compare
PR #27271: Size comparison from 5ed31da to aee4371 Increases (3 builds for bl702, nrfconnect, qpg)
Decreases (3 builds for cc32xx, nrfconnect, qpg)
Full report (11 builds for bl602, bl702, cc32xx, mbed, nrfconnect, qpg)
|
Waiting for APIs to stabilize.
bzbarsky-apple
force-pushed
the
robotic-vacuum-darwin-api
branch
from
June 16, 2023 15:38
aee4371
to
58b692f
Compare
PR #27271: Size comparison from 90f4f7c to 58b692f Increases (8 builds for cyw30739, nrfconnect, psoc6, telink)
Decreases (8 builds for bl702, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jun 16, 2023
woody-apple
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for APIs to stabilize.