-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[esp32] Fix compilation error for esp32 based ble-controller #27231
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
PSONALl:ble-compilation-fix
Jun 14, 2023
Merged
[esp32] Fix compilation error for esp32 based ble-controller #27231
bzbarsky-apple
merged 1 commit into
project-chip:master
from
PSONALl:ble-compilation-fix
Jun 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
app
config
controller
documentation
Improvements or additions to documentation
esp32
examples
inet
lib
platform
support
test driver
labels
Jun 14, 2023
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex and
harsha-rajendran
June 14, 2023 11:47
pullapprove
bot
requested review from
sharadb-amazon,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
June 14, 2023 11:47
PSONALl
force-pushed
the
ble-compilation-fix
branch
from
June 14, 2023 11:49
4db2df9
to
77e4133
Compare
github-actions
bot
removed
support
test driver
lib
inet
examples
app
controller
config
documentation
Improvements or additions to documentation
labels
Jun 14, 2023
PR #27231: Size comparison from ecd0f6f to 77e4133 Increases (6 builds for cyw30739, esp32, psoc6, qpg, telink)
Decreases (11 builds for bl602, bl702, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jun 14, 2023
@PSONALl why does CI not catch this error? |
tcarmelveilleux
approved these changes
Jun 14, 2023
bzbarsky-apple
approved these changes
Jun 14, 2023
The ble-controller example is not present in the connectedhomeip repo yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes compilation error for ble-controller application over esp32
Error received was: