CASE: Handle failure if unable to schedule handle/send sigma3c #27226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mlepage-google
mlepage-google
approved these changes
Jun 27, 2023
bzbarsky-apple
approved these changes
Jun 28, 2023
|
PR #27226: Size comparison from a7edf3d to cf2eb88 Increases above 0.2%:
Increases (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
- We are no longer unregistering the unsolicit message hander for sigma1. Based on handshake state and failure to schedule work, decide what to do. 1. If in middle of handshake but it's zombie, tear down the handshake. 2. If still in middle of handshake, return without responding. 3. Otherwise, jsut do a new handshake. - Added APIs in helper to check if it fails to schedule after work callback and to re run it from foreground thread. - Added wrapper around the APIs for HandleSigma3 and SendSigma3 cases.
Added the accessor for CASESession state. Now, all the logic for checking and resetting stays with CASESession
Co-authored-by: Marc Lepage <[email protected]>
Co-authored-by: Marc Lepage <[email protected]>
|
PR #27226: Size comparison from df986c9 to ede7156 Increases above 0.2%:
Increases (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
pushed a commit
that referenced
this pull request
Jul 5, 2023
* Cleanup in aisle CASESession (#26339) * Cleanup in aisle CASESession * Reduce nesting in function * CASE: Handle failure if unable to schedule handle/send sigma3c (#27226) * CASE: Handle failure if unable to schedule handle/send sigma3c - We are no longer unregistering the unsolicit message hander for sigma1. Based on handshake state and failure to schedule work, decide what to do. 1. If in middle of handshake but it's zombie, tear down the handshake. 2. If still in middle of handshake, return without responding. 3. Otherwise, jsut do a new handshake. - Added APIs in helper to check if it fails to schedule after work callback and to re run it from foreground thread. - Added wrapper around the APIs for HandleSigma3 and SendSigma3 cases. * Restyled by clang-format * Address review comments Added the accessor for CASESession state. Now, all the logic for checking and resetting stays with CASESession * Fix some API docs * Addressed review comments * Update src/protocols/secure_channel/CASESession.cpp Co-authored-by: Marc Lepage <[email protected]> * Update src/protocols/secure_channel/CASEServer.cpp Co-authored-by: Marc Lepage <[email protected]> * Moved status check before setting atomic variable * fix build failures --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Justin Wood <[email protected]> Co-authored-by: Marc Lepage <[email protected]> --------- Co-authored-by: Marc Lepage <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Justin Wood <[email protected]>
This was referenced Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Sending and Handling Sigma3 is an async process and divided into three parts, Sigma3a, Sigma3b, and Sigma3c.
Sigma3a schedules Sigma3b, and Sigma3b is suppose to schedule the Sigma3c.
If We fail to schedule Sigma3c then, we are in the state where the only option to recover is reboot. Problem is more described in #25695 (comment) and logs in #26737 has hit this problem.
Fixes #26737 and completes below item from #26280
Change Overview
Implemented the suggestion provided by Marc here: #26280 (comment)
We are no longer unregistering the unsolicit message hander for sigma1. Based on handshake state and failure to schedule work, decide what to do:
Added APIs in helper to check if it fails to schedule after work callback and to re run it from foreground thread.
Added wrapper around the APIs for HandleSigma3 and SendSigma3 cases.
Tests
connectedhomeip/src/protocols/secure_channel/CASESession.cpp
Line 230 in 643f7aa
Follow ups to do
RegisterUnsolicitedMessageHandlerForType()can be moved out fromPrepareForSessionEstablishment(), this gets called every time after case is established/failed.IsSendSigma3PermanentlyBlockedOnBackgroundWork()andUnblockSendSigma3FromForegroundWork()from CASEClient.#27474 and #27473