Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Silabs] Enable Persistent Subs by default on all builds #27222

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions examples/platform/silabs/efr32/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,6 @@ declare_args() {
chip_config_use_icd_subscription_callbacks = enable_sleepy_device
}

# Use persitent subscriptions for IC devices
chip_persist_subscriptions = enable_sleepy_device

silabs_common_plat_dir = "${chip_root}/examples/platform/silabs"

import("${silabs_common_plat_dir}/args.gni")
Expand Down
3 changes: 2 additions & 1 deletion src/platform/device.gni
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@ declare_args() {

# Enable Subscription persistence / resumption for CI and supported platforms
tcarmelveilleux marked this conversation as resolved.
Show resolved Hide resolved
if (chip_device_platform == "darwin" || chip_device_platform == "linux" ||
chip_device_platform == "esp32" || chip_device_platform == "fake") {
chip_device_platform == "esp32" || chip_device_platform == "fake" ||
chip_device_platform == "efr32" || chip_device_platform == "SiWx917") {
chip_persist_subscriptions = true
} else {
chip_persist_subscriptions = false
Expand Down