Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for MTROTAProviderDelegate. #27206

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

Makes it clear how to handle BDX uris and file designators

Makes it clear how to handle BDX uris and file designators
@github-actions
Copy link

github-actions bot commented Jun 12, 2023

PR #27206: Size comparison from 452d3b4 to 1ace545

Increases (9 builds for bl702, cc32xx, k32w, psoc6, telink)
platform target config section 452d3b4 1ace545 change % change
bl702 lighting-app bl702 (read/write) 1172179 1172183 4 0.0
.debug_info 45173892 45173893 1 0.0
.text 943580 943582 2 0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 23111423 23111424 1 0.0
k32w lock k32w0+release (read only) 556076 556092 16 0.0
.text 555540 555556 16 0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 26074794 26074795 1 0.0
telink all-clusters-app tlsr9518adk80d text 707594 707596 2 0.0
bridge-app tlsr9518adk80d (read/write) 928784 928792 8 0.0
text 641888 641890 2 0.0
light-switch-app tlsr9518adk80d text 599646 599648 2 0.0
lighting-app-factory-data tlsr9518adk80d (read/write) 976404 976412 8 0.0
text 686228 686230 2 0.0
ota-requestor-app tlsr9518adk80d text 606864 606866 2 0.0
Decreases (7 builds for bl702, psoc6, telink)
platform target config section 452d3b4 1ace545 change % change
bl702 lighting-app bl702+rpc .debug_info 50125922 50125921 -1 -0.0
.text 1017240 1017238 -2 -0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 26522659 26522658 -1 -0.0
telink lighting-app tlsr9518adk80d text 678712 678710 -2 -0.0
lighting-app-rpc tlsr9518adk80d (read/write) 1034132 1034124 -8 -0.0
text 723394 723392 -2 -0.0
lighting-app-shell tlsr9518adk80d (read/write) 1065888 1065880 -8 -0.0
text 743750 743748 -2 -0.0
temperature-measurement-app tlsr9518adk80d text 576758 576756 -2 -0.0
window-covering tlsr9518adk80d (read/write) 890352 890344 -8 -0.0
text 610928 610924 -4 -0.0
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 452d3b4 1ace545 change % change
bl602 lighting-app bl602 (read/write) 1368146 1368146 0 0.0
.bss 88182 88182 0 0.0
.data 9584 9584 0 0.0
.text 1048448 1048448 0 0.0
bl602+rpc (read/write) 1415258 1415258 0 0.0
.bss 96230 96230 0 0.0
.data 9984 9984 0 0.0
.text 1080184 1080184 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1172179 1172183 4 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 77777 77777 0 0.0
.bss_psram 24656 24656 0 0.0
.comment 48 48 0 0.0
.data 3576 3576 0 0.0
.debug_abbrev 1553252 1553252 0 0.0
.debug_aranges 149608 149608 0 0.0
.debug_frame 550600 550600 0 0.0
.debug_info 45173892 45173893 1 0.0
.debug_line 5586716 5586716 0 0.0
.debug_loc 3790744 3790744 0 0.0
.debug_ranges 394064 394064 0 0.0
.debug_str 4344280 4344280 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 104896 104896 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 580739 580739 0 0.0
.symtab 173712 173712 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
943580 943582 2 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1269959 1269959 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 85825 85825 0 0.0
.bss_psram 25056 25056 0 0.0
.comment 48 48 0 0.0
.data 4136 4136 0 0.0
.debug_abbrev 1712443 1712443 0 0.0
.debug_aranges 157912 157912 0 0.0
.debug_frame 578680 578680 0 0.0
.debug_info 50125922 50125921 -1 -0.0
.debug_line 6003162 6003162 0 0.0
.debug_loc 3993882 3993882 0 0.0
.debug_ranges 419560 419560 0 0.0
.debug_str 4770334 4770334 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 119432 119432 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 642242 642242 0 0.0
.symtab 192272 192272 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1017240 1017238 -2 -0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 606178 606178 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 952093 952093 0 0.0
.debug_aranges 118920 118920 0 0.0
.debug_frame 406188 406188 0 0.0
.debug_info 23111423 23111424 1 0.0
.debug_line 2880814 2880814 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1726586 1726586 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 107524 107524 0 0.0
.debug_str 3786770 3786770 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104546 104546 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 484580 484580 0 0.0
.symtab 287712 287712 0 0.0
.text 499512 499512 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 542259 542259 0 0.0
.app_xip_area 434877 434877 0 0.0
.bss 62360 62360 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 529267 529267 0 0.0
.app_xip_area 416757 416757 0 0.0
.bss 67480 67480 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566659 566659 0 0.0
.app_xip_area 460213 460213 0 0.0
.bss 61472 61472 0 0.0
.data 668 668 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 531051 531051 0 0.0
.app_xip_area 422037 422037 0 0.0
.bss 63960 63960 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 986508 986508 0 0.0
.bss 179872 179872 0 0.0
.data 2144 2144 0 0.0
.text 804472 804472 0 0.0
BRD4187C (read/write) 1019784 1019784 0 0.0
.bss 159596 159596 0 0.0
.data 2788 2788 0 0.0
.text 857380 857380 0 0.0
lock-app BRD4161A+wf200 (read/write) 1069144 1069144 0 0.0
.bss 174160 174160 0 0.0
.data 2152 2152 0 0.0
.text 892812 892812 0 0.0
window-app BRD4187C (read/write) 1088824 1088824 0 0.0
.bss 142572 142572 0 0.0
.data 2680 2680 0 0.0
.text 943552 943552 0 0.0
esp32 all-clusters-app c3devkit (read only) 1074716 1074716 0 0.0
(read/write) 1583792 1583792 0 0.0
.dram0.bss 75280 75280 0 0.0
.dram0.data 13940 13940 0 0.0
.flash.rodata 215432 215432 0 0.0
.flash.text 1074716 1074716 0 0.0
.iram0.text 76740 76740 0 0.0
m5stack (read only) 1122763 1122763 0 0.0
(read/write) 494246 494246 0 0.0
.dram0.bss 80768 80768 0 0.0
.dram0.data 34304 34304 0 0.0
.flash.rodata 244024 244024 0 0.0
.flash.text 1117379 1117379 0 0.0
.iram0.text 126055 126055 0 0.0
k32w contact k32w0+release (read only) 584796 584796 0 0.0
(read/write) 90108 90108 0 0.0
.bss 66104 66104 0 0.0
.data 2168 2168 0 0.0
.text 584260 584260 0 0.0
light k32w0+release (read only) 583484 583484 0 0.0
(read/write) 89756 89756 0 0.0
.bss 65768 65768 0 0.0
.data 2156 2156 0 0.0
.text 582948 582948 0 0.0
lock k32w0+release (read only) 556076 556092 16 0.0
(read/write) 87556 87556 0 0.0
.bss 63632 63632 0 0.0
.data 2100 2100 0 0.0
.text 555540 555556 16 0.0
linux chip-tool-ipv6only arm64 (read only) 15214040 15214040 0 0.0
(read/write) 787368 787368 0 0.0
.bss 34376 34376 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 727736 727736 0 0.0
.dynamic 560 560 0 0.0
.got 16992 16992 0 0.0
.init 24 24 0 0.0
.init_array 232 232 0 0.0
.rodata 635992 635992 0 0.0
.text 12715364 12715364 0 0.0
thermostat-no-ble arm64 (read only) 2616820 2616820 0 0.0
(read/write) 142968 142968 0 0.0
.bss 52360 52360 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 79240 79240 0 0.0
.dynamic 560 560 0 0.0
.got 5520 5520 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 129712 129712 0 0.0
.text 2221636 2221636 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2497920 2497920 0 0.0
.bss 216304 216304 0 0.0
.data 5144 5144 0 0.0
.text 1460604 1460604 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1209952 1209952 0 0.0
bss 154745 154745 0 0.0
rodata 137380 137380 0 0.0
text 838768 838768 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1312804 1312804 0 0.0
bss 138075 138075 0 0.0
rodata 132816 132816 0 0.0
text 751200 751200 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1148308 1148308 0 0.0
bss 153377 153377 0 0.0
rodata 111096 111096 0 0.0
text 804764 804764 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841984 841984 0 0.0
(read/write) 1728204 1728204 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188796 188796 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2560 2560 0 0.0
.debug_abbrev 1297177 1297177 0 0.0
.debug_aranges 148632 148632 0 0.0
.debug_frame 497676 497676 0 0.0
.debug_info 32271783 32271783 0 0.0
.debug_line 4034705 4034705 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2300833 2300833 0 0.0
.debug_rnglists 144093 144093 0 0.0
.debug_str 4350301 4350301 0 0.0
.heap 841984 841984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 750884 750884 0 0.0
.symtab 478784 478784 0 0.0
.text 1528460 1528460 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 843312 843312 0 0.0
(read/write) 1660668 1660668 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187468 187468 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2560 2560 0 0.0
.debug_abbrev 1284935 1284935 0 0.0
.debug_aranges 147384 147384 0 0.0
.debug_frame 498620 498620 0 0.0
.debug_info 31733867 31733867 0 0.0
.debug_line 4040307 4040307 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2285664 2285664 0 0.0
.debug_rnglists 142539 142539 0 0.0
.debug_str 4333231 4333231 0 0.0
.heap 843312 843312 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 699765 699765 0 0.0
.symtab 459904 459904 0 0.0
.text 1462252 1462252 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849560 849560 0 0.0
(read/write) 1593268 1593268 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 181388 181388 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1122520 1122520 0 0.0
.debug_aranges 137720 137720 0 0.0
.debug_frame 462528 462528 0 0.0
.debug_info 26522659 26522658 -1 -0.0
.debug_line 3611221 3611221 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 2126532 2126532 0 0.0
.debug_rnglists 132531 132531 0 0.0
.debug_str 4147305 4147305 0 0.0
.heap 849560 849560 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 623349 623349 0 0.0
.symtab 425328 425328 0 0.0
.text 1401100 1401100 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 821960 821960 0 0.0
(read/write) 1626308 1626308 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208988 208988 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1104792 1104792 0 0.0
.debug_aranges 136112 136112 0 0.0
.debug_frame 456880 456880 0 0.0
.debug_info 26074794 26074795 1 0.0
.debug_line 3550580 3550580 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 2100291 2100291 0 0.0
.debug_rnglists 130376 130376 0 0.0
.debug_str 4107804 4107804 0 0.0
.heap 821960 821960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 596481 596481 0 0.0
.symtab 416928 416928 0 0.0
.text 1406540 1406540 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1171016 1171016 0 0.0
.bss 99952 99952 0 0.0
.data 788 788 0 0.0
.text 617856 617856 0 0.0
lock-app qpg6105+debug (read/write) 1140368 1140368 0 0.0
.bss 94832 94832 0 0.0
.data 792 792 0 0.0
.text 587212 587212 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1033916 1033916 0 0.0
bss 97660 97660 0 0.0
text 707594 707596 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 961064 961064 0 0.0
bss 96176 96176 0 0.0
text 664852 664852 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 928784 928792 8 0.0
bss 100308 100308 0 0.0
text 641888 641890 2 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 860452 860452 0 0.0
bss 89968 89968 0 0.0
text 585022 585022 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 876776 876776 0 0.0
bss 90136 90136 0 0.0
text 599646 599648 2 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 965032 965032 0 0.0
bss 98500 98500 0 0.0
text 678712 678710 -2 -0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 976404 976412 8 0.0
bss 102748 102748 0 0.0
text 686228 686230 2 0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1034132 1034124 -8 -0.0
bss 100064 100064 0 0.0
text 723394 723392 -2 -0.0
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1065888 1065880 -8 -0.0
bss 111140 111140 0 0.0
text 743750 743748 -2 -0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 915524 915524 0 0.0
bss 90632 90632 0 0.0
text 613648 613648 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 883052 883052 0 0.0
bss 91244 91244 0 0.0
text 606864 606866 2 0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 866012 866012 0 0.0
bss 90100 90100 0 0.0
text 590744 590744 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 853072 853072 0 0.0
bss 89900 89900 0 0.0
text 581126 581126 0 0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 849228 849228 0 0.0
bss 89808 89808 0 0.0
text 576758 576756 -2 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 894972 894972 0 0.0
bss 90344 90344 0 0.0
text 616006 616006 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 890352 890344 -8 -0.0
bss 90636 90636 0 0.0
text 610928 610924 -4 -0.0

@bzbarsky-apple
Copy link
Contributor Author

Fast-tracking platform-specific change with platform owner review.

@bzbarsky-apple bzbarsky-apple merged commit 95ebb9f into project-chip:master Jun 13, 2023
@bzbarsky-apple bzbarsky-apple deleted the better-docs branch June 13, 2023 14:00
@bzbarsky-apple bzbarsky-apple restored the better-docs branch June 13, 2023 16:39
@bzbarsky-apple bzbarsky-apple deleted the better-docs branch June 13, 2023 16:39
@bzbarsky-apple bzbarsky-apple restored the better-docs branch June 13, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants