-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[matter_yamltests] Allow response to specify an endpoint/cluster/comm… #27148
Merged
mergify
merged 1 commit into
project-chip:master
from
vivien-apple:MatterYamlTests_ValidateSource
Jun 20, 2023
Merged
[matter_yamltests] Allow response to specify an endpoint/cluster/comm… #27148
mergify
merged 1 commit into
project-chip:master
from
vivien-apple:MatterYamlTests_ValidateSource
Jun 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no and
ksperling-apple
June 8, 2023 11:54
pullapprove
bot
requested review from
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
June 8, 2023 11:54
PR #27148: Size comparison from d4c7d47 to d2cc07a Increases (7 builds for esp32, nrfconnect, psoc6, telink)
Decreases (15 builds for bl602, bl702, cc32xx, nrfconnect, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jun 8, 2023
…and/attribute/event for validating responses that contains multiple results or to ensure that a single response is the one expected and not a random response from a different source
vivien-apple
force-pushed
the
MatterYamlTests_ValidateSource
branch
from
June 19, 2023 08:37
d2cc07a
to
e7c0bb4
Compare
PR #27148: Size comparison from f5c4621 to e7c0bb4 Increases (21 builds for bl602, bl702, cyw30739, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for esp32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and/attribute/event for validating responses that contains multiple results or to ensure that a single response is the one expected and not a random response from a different source
Problem
When running YAML tests and when a response comes back, the current code does not check if the response if coming from what has been requested.
This PR add that if and only if the response contains the needed informations.