Improvements in Python testing support #27116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem:
- It was no longer possible to run `matter_testing_support.py`-based
tests on already commissioned devices due to changes in command
line logic that impacted fabric ID selection and broke stack init.
- Some variables that contained multiple entries in
`matter_test_support.py` were singular which was somewhat confusing
and a change from the initial semantics where unique values only
were allowed.
Changes in this PR:
- Pluralize required fields
- Fix running tests without commissioning
- Improve setup_payload decoder module API
- Give access to raw TLV results for reads, not just subs
Testing done:
- Re-ran `TC_DA_1_7.py` with updates (thanks cecille@)
- Re-ran `TC_CGEN_2_4.py` with updates.
- Used updated APIs in a seperate branch (upcoming)
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
pullapprove
bot
requested review from
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #27116: Size comparison from 2520f47 to af643ce Increases (9 builds for bl602, bl702, esp32, telink)
Decreases (9 builds for psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
cecille
approved these changes
Jun 7, 2023
andy31415
approved these changes
Jun 7, 2023
ReneJosefsen
approved these changes
Jun 7, 2023
|
PR #27116: Size comparison from 2520f47 to 2d00115 Increases (11 builds for bl602, bl702, cc32xx, cyw30739, psoc6, qpg)
Decreases (13 builds for bl702, cc32xx, cyw30739, k32w, psoc6, qpg)
Full report (21 builds for bl602, bl702, cc32xx, cyw30739, k32w, linux, mbed, psoc6, qpg)
|
bzbarsky-apple
approved these changes
Jun 7, 2023
|
PR #27116: Size comparison from 2520f47 to 73fb6df Increases (6 builds for bl602, bl702, cc32xx, qpg)
Decreases (4 builds for bl702, cc32xx, qpg)
Full report (10 builds for bl602, bl702, cc32xx, linux, mbed, qpg)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
- It was no longer possible to run
matter_testing_support.py-basedtests on already commissioned devices due to changes in command
line logic that impacted fabric ID selection and broke stack init.
- Some variables that contained multiple entries in
matter_test_support.pywere singular which was somewhat confusingand a change from the initial semantics where unique values only
were allowed.
Changes in this PR:
- Pluralize required fields
- Fix running tests without commissioning
- Improve setup_payload decoder module API
- Give access to raw TLV results for reads, not just subs
Testing done:
- Re-ran
TC_DA_1_7.pywith updates (thanks cecille@)- Re-ran
TC_CGEN_2_4.pywith updates.- Used updated APIs in a seperate branch (upcoming)