-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrfconnect] Added calculating unique id length based on kconfig #27032
Merged
kkasperczyk-no
merged 1 commit into
project-chip:master
from
kkasperczyk-no:unique_id_length_fix
Jun 5, 2023
Merged
[nrfconnect] Added calculating unique id length based on kconfig #27032
kkasperczyk-no
merged 1 commit into
project-chip:master
from
kkasperczyk-no:unique_id_length_fix
Jun 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
June 2, 2023 08:42
pullapprove
bot
requested review from
younghak-hwang,
yufengwangca and
yunhanw-google
June 2, 2023 08:42
PR #27032: Size comparison from 73c18db to b58b711 Increases (11 builds for cyw30739, nrfconnect, psoc6, qpg, telink)
Decreases (13 builds for bl602, bl702, cc32xx, nrfconnect, psoc6, qpg, telink)
Full report (69 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
kkasperczyk-no
force-pushed
the
unique_id_length_fix
branch
from
June 2, 2023 12:31
b58b711
to
71dc663
Compare
PR #27032: Size comparison from 73c18db to 71dc663 Increases (1 build for qpg)
Full report (4 builds for cc32xx, mbed, qpg)
|
kkasperczyk-no
force-pushed
the
unique_id_length_fix
branch
from
June 2, 2023 12:59
71dc663
to
986a8da
Compare
PR #27032: Size comparison from 8d6add8 to 986a8da Increases (14 builds for cyw30739, nrfconnect, psoc6, telink)
Decreases (7 builds for bl602, esp32, psoc6, telink)
Full report (69 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jun 2, 2023
kkasperczyk-no
force-pushed
the
unique_id_length_fix
branch
from
June 5, 2023 05:48
986a8da
to
aa4f8b0
Compare
Currently the unique id length is fixed to 16 B and in nrfconnect platform we allow to set unique id value through kconfig, which may lead to a problem that length of selected data will not match the unique id length hardcoded to 16 B. Added calculating the unique id length based on Kconfig or assigning the max value assumed for the factory data storage.
kkasperczyk-no
force-pushed
the
unique_id_length_fix
branch
from
June 5, 2023 05:51
aa4f8b0
to
f9becfe
Compare
LuDuda
approved these changes
Jun 5, 2023
PR #27032: Size comparison from 275341e to f9becfe Increases (10 builds for bl702, esp32, nrfconnect, psoc6, telink)
Decreases (13 builds for bl602, cc32xx, k32w, psoc6, qpg, telink)
Full report (69 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
maciejbaczmanski
pushed a commit
to maciejbaczmanski/connectedhomeip
that referenced
this pull request
Jul 15, 2024
…n kconfig (project-chip#27032) Currently the unique id length is fixed to 16 B and in nrfconnect platform we allow to set unique id value through kconfig, which may lead to a problem that length of selected data will not match the unique id length hardcoded to 16 B. Added calculating the unique id length based on Kconfig or assigning the max value assumed for the factory data storage. (cherry picked from commit 8ba86ec)
maciejbaczmanski
pushed a commit
to maciejbaczmanski/connectedhomeip
that referenced
this pull request
Jul 15, 2024
… based on kconfig (project-chip#27032)" This reverts commit b9d0a03.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the unique id length is fixed to 16 B and in nrfconnect
platform we allow to set unique id value through kconfig, which may
lead to a problem that length of selected data will not match the
unique id length hardcoded to 16 B.
Added calculating the unique id length based on Kconfig
or assigning the max value assumed for the factory data storage.