-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Linux build break when thread is disabled #27017
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
June 1, 2023 16:04
pullapprove
bot
requested review from
msandstedt,
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
June 1, 2023 16:04
andy31415
approved these changes
Jun 1, 2023
PR #27017: Size comparison from 1887986 to 1781ab2 Increases (1 build for cc32xx)
Decreases (1 build for bl602)
Full report (13 builds for bl602, bl702, cc32xx, linux, mbed, nrfconnect, qpg)
|
chrisdecenzo
approved these changes
Jun 1, 2023
bzbarsky-apple
approved these changes
Jun 1, 2023
PR #27017: Size comparison from 592a6f0 to 82e7c1c Increases (6 builds for bl602, bl702, cyw30739, esp32, nrfconnect, psoc6)
Decreases (3 builds for cc32xx, psoc6)
Full report (27 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #27017: Size comparison from 28e0423 to eeac630 Increases (2 builds for bl602, cc32xx)
Decreases (8 builds for bl602, bl702, nrfconnect, psoc6, qpg)
Full report (24 builds for bl602, bl702, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #27017: Size comparison from 28e0423 to ce9542e Increases (16 builds for bl702, cc32xx, esp32, linux, psoc6, telink)
Decreases (15 builds for bl602, bl702, cc32xx, cyw30739, linux, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Building without thread support is broken on Linux.
Changes
Testing
Tested locally with: