-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin] MTRDevice should coalesce reads and avoid duplicates #26999
Merged
bzbarsky-apple
merged 16 commits into
project-chip:master
from
jtung-apple:jtung/mtrdevice-coalescing-reads
Jun 3, 2023
Merged
[Darwin] MTRDevice should coalesce reads and avoid duplicates #26999
bzbarsky-apple
merged 16 commits into
project-chip:master
from
jtung-apple:jtung/mtrdevice-coalescing-reads
Jun 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
kkasperczyk-no and
ksperling-apple
June 1, 2023 07:51
PR #26999: Size comparison from 68621d0 to 6d7b16f Increases (9 builds for cc32xx, nrfconnect, qpg, telink)
Decreases (6 builds for bl602, esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #26999: Size comparison from 68621d0 to 173585e Increases (2 builds for mbed, nrfconnect)
Decreases (2 builds for nrfconnect)
Full report (4 builds for mbed, nrfconnect)
|
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
jtung-apple
force-pushed
the
jtung/mtrdevice-coalescing-reads
branch
from
June 1, 2023 20:05
c863d9f
to
ab19c4e
Compare
… to avoid potential race
jtung-apple
force-pushed
the
jtung/mtrdevice-coalescing-reads
branch
from
June 1, 2023 20:06
ab19c4e
to
bf6cff5
Compare
PR #26999: Size comparison from 860e934 to 2987aa1 Increases (14 builds for bl702, nrfconnect, psoc6, telink)
Decreases (8 builds for bl602, cc32xx, nrfconnect, qpg, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Co-authored-by: Boris Zbarsky <[email protected]>
PR #26999: Size comparison from 860e934 to b803b39 Increases (15 builds for bl602, bl702, cc32xx, psoc6, telink)
Decreases (4 builds for bl702, esp32, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jun 2, 2023
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Fast-tracking platform-specific change with platform owner review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds two facilities to
MTRAsyncCallbackWorkQueue
andMTRAsyncCallbackQueueWorkItem
API:And also amended MTRDevice to adopt these facilities to:
Testing: currently this is only passing unit tests for the
MTRAsyncCallbackWorkQueue
andMTRAsyncCallbackQueueWorkItem
API changes. Further testing is needed to verify MTRDevice changes are working correctly.