-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Network Commissioning cluster XML to match specification. #26988
Update Network Commissioning cluster XML to match specification. #26988
Conversation
PR #26988: Size comparison from 77b1596 to 530bc26 Increases (5 builds for bl602, bl702, cc32xx, linux)
Full report (16 builds for bl602, bl702, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
Is the removal of the zzz_generated Darwin files in the first commit intentional, they seem unrelated to this change? |
530bc26
to
21cfd05
Compare
It is. That code should not exist, did not exist, was incorrectly re-added by a bad merge in another PR, and mentions some of these types (which is why I noticed it). |
PR #26988: Size comparison from 77b1596 to 21cfd05 Increases (12 builds for bl602, bl702, cc32xx, cyw30739, linux, psoc6)
Decreases (3 builds for esp32, nrfconnect, psoc6)
Full report (38 builds for bl602, bl702, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
21cfd05
to
e6c4ce7
Compare
PR #26988: Size comparison from 2b6b8ef to e6c4ce7 Increases (16 builds for bl702, cc32xx, esp32, k32w, linux, psoc6, telink)
Decreases (9 builds for bl602, cyw30739, psoc6, telink)
Full report (42 builds for bl602, bl702, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
e6c4ce7
to
1a83cbb
Compare
PR #26988: Size comparison from 2b6b8ef to 1a83cbb Increases (15 builds for bl702, cc32xx, esp32, k32w, linux, psoc6, telink)
Decreases (8 builds for bl602, bl702, nrfconnect, psoc6, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
REVIEW NOTE: Only the first of the three changesets is manually-written.
Spec changes happened in https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/6193
Fixes #25008