Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement kotlin setup-payload phase II #26963

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Implement kotlin setup-payload phase II #26963

merged 3 commits into from
Jun 2, 2023

Conversation

yufengwangca
Copy link
Contributor

@yufengwangca yufengwangca commented May 30, 2023 •
edited
Loading

This is the second phase of setuppayload implementation in kotlin, which convert ManualSetupPayloadGenerator and ManualSetupPayloadParser to kotlin, the final goal is to implement setup payload completely in kotlin and deprecate the existing src/setup_payload implemented in java/c++.

Testing:
Leverage the existing CI tests using java_matter_controller, unit tests will be added later after convert all to kotlin so that we don't need to figure out how to load native lib to JUnit

@andy31415
Copy link
Contributor

@yufengwangca in https://github.com/project-chip/connectedhomeip/blob/master/.github/workflows/java-tests.yaml#L93 we now have the ability to run java unit tests.

Would we be able to add unit tests for these classes and functionality as well?

@github-actions
Copy link

github-actions bot commented Jun 1, 2023 •
edited
Loading

PR #26963: Size comparison from 28e0423 to 4879135

Increases (9 builds for bl602, bl702, esp32, psoc6, telink)
platform target config section 28e0423 4879135 change % change
bl602 lighting-app bl602 (read/write) 1356026 1356034 8 0.0
.text 1036102 1036106 4 0.0
bl702 lighting-app bl702 .debug_info 44560370 44560371 1 0.0
.text 966458 966460 2 0.0
esp32 all-clusters-app c3devkit (read only) 1069166 1069170 4 0.0
.flash.text 1069166 1069170 4 0.0
m5stack (read/write) 493822 493826 4 0.0
.flash.rodata 243664 243668 4 0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 25659344 25659345 1 0.0
telink all-clusters-app tlsr9518adk80d text 703656 703660 4 0.0
lighting-app-shell tlsr9518adk80d text 742960 742962 2 0.0
temperature-measurement-app tlsr9518adk80d text 576156 576158 2 0.0
window-covering tlsr9518adk80d text 610058 610060 2 0.0
Decreases (10 builds for bl602, bl702, cyw30739, psoc6, telink)
platform target config section 28e0423 4879135 change % change
bl602 lighting-app bl602+rpc .text 1067732 1067730 -2 -0.0
bl702 lighting-app bl702+rpc .debug_info 49505299 49505297 -2 -0.0
.text 1040374 1040370 -4 -0.0
cyw30739 switch cyw930739m2evb_01 (read/write) 530915 530907 -8 -0.0
.app_xip_area 421901 421893 -8 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 31666227 31666226 -1 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 31218086 31218085 -1 -0.0
light cy8ckit_062s2_43012 .debug_info 26093341 26093340 -1 -0.0
telink bridge-app tlsr9518adk80d (read/write) 928352 928344 -8 -0.0
text 641538 641536 -2 -0.0
lighting-app-rpc tlsr9518adk80d text 722622 722620 -2 -0.0
ota-requestor-app tlsr9518adk80d text 606082 606080 -2 -0.0
thermostat tlsr9518adk80d text 615118 615116 -2 -0.0
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 28e0423 4879135 change % change
bl602 lighting-app bl602 (read/write) 1356026 1356034 8 0.0
.bss 87886 87886 0 0.0
.data 9648 9648 0 0.0
.text 1036102 1036106 4 0.0
bl602+rpc (read/write) 1403022 1403022 0 0.0
.bss 95934 95934 0 0.0
.data 10040 10040 0 0.0
.text 1067732 1067730 -2 -0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1187903 1187903 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67585 67585 0 0.0
.bss_psram 24656 24656 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1551313 1551313 0 0.0
.debug_aranges 148448 148448 0 0.0
.debug_frame 545792 545792 0 0.0
.debug_info 44560370 44560371 1 0.0
.debug_line 5558874 5558874 0 0.0
.debug_loc 3781197 3781197 0 0.0
.debug_ranges 388184 388184 0 0.0
.debug_str 4315652 4315652 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107168 107168 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 582090 582090 0 0.0
.symtab 175536 175536 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
966458 966460 2 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1277699 1277699 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75633 75633 0 0.0
.bss_psram 25056 25056 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1710355 1710355 0 0.0
.debug_aranges 156736 156736 0 0.0
.debug_frame 573804 573804 0 0.0
.debug_info 49505299 49505297 -2 -0.0
.debug_line 5974916 5974916 0 0.0
.debug_loc 3984360 3984360 0 0.0
.debug_ranges 413664 413664 0 0.0
.debug_str 4741122 4741122 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121712 121712 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 643593 643593 0 0.0
.symtab 194096 194096 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1040374 1040370 -4 -0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 605850 605850 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 951194 951194 0 0.0
.debug_aranges 117584 117584 0 0.0
.debug_frame 401012 401012 0 0.0
.debug_info 22707684 22707684 0 0.0
.debug_line 2853264 2853264 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1711471 1711471 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 106453 106453 0 0.0
.debug_str 3756505 3756505 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104458 104458 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 484233 484233 0 0.0
.symtab 287408 287408 0 0.0
.text 499272 499272 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 541995 541995 0 0.0
.app_xip_area 434621 434621 0 0.0
.bss 62352 62352 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 529387 529387 0 0.0
.app_xip_area 416877 416877 0 0.0
.bss 67480 67480 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566283 566283 0 0.0
.app_xip_area 459837 459837 0 0.0
.bss 61472 61472 0 0.0
.data 668 668 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 530915 530907 -8 -0.0
.app_xip_area 421901 421893 -8 -0.0
.bss 63960 63960 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 987924 987924 0 0.0
.bss 179856 179856 0 0.0
.data 2144 2144 0 0.0
.text 805904 805904 0 0.0
BRD4187C (read/write) 1019560 1019560 0 0.0
.bss 159588 159588 0 0.0
.data 2788 2788 0 0.0
.text 857164 857164 0 0.0
lock-app BRD4161A+wf200 (read/write) 1069240 1069240 0 0.0
.bss 174160 174160 0 0.0
.data 2152 2152 0 0.0
.text 892908 892908 0 0.0
window-app BRD4187C (read/write) 1090488 1090488 0 0.0
.bss 142572 142572 0 0.0
.data 2680 2680 0 0.0
.text 945216 945216 0 0.0
esp32 all-clusters-app c3devkit (read only) 1069166 1069170 4 0.0
(read/write) 1584576 1584576 0 0.0
.dram0.bss 75704 75704 0 0.0
.dram0.data 13964 13964 0 0.0
.flash.rodata 215768 215768 0 0.0
.flash.text 1069166 1069170 4 0.0
.iram0.text 76740 76740 0 0.0
m5stack (read only) 1115123 1115123 0 0.0
(read/write) 493822 493826 4 0.0
.dram0.bss 80704 80704 0 0.0
.dram0.data 34304 34304 0 0.0
.flash.rodata 243664 243668 4 0.0
.flash.text 1109739 1109739 0 0.0
.iram0.text 126055 126055 0 0.0
k32w contact k32w0+release (read only) 584652 584652 0 0.0
(read/write) 90108 90108 0 0.0
.bss 66104 66104 0 0.0
.data 2168 2168 0 0.0
.text 584116 584116 0 0.0
light k32w0+release (read only) 583612 583612 0 0.0
(read/write) 89756 89756 0 0.0
.bss 65768 65768 0 0.0
.data 2156 2156 0 0.0
.text 583076 583076 0 0.0
lock k32w0+release (read only) 556156 556156 0 0.0
(read/write) 87556 87556 0 0.0
.bss 63632 63632 0 0.0
.data 2100 2100 0 0.0
.text 555620 555620 0 0.0
linux all-clusters-app debug (read only) 3239341 3239341 0 0.0
(read/write) 156952 156952 0 0.0
.bss 58784 58784 0 0.0
.data 2160 2160 0 0.0
.data.rel.ro 89496 89496 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 231336 231336 0 0.0
.text 2818501 2818501 0 0.0
all-clusters-minimal-app debug (read only) 3036109 3036109 0 0.0
(read/write) 145000 145000 0 0.0
.bss 57344 57344 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 79128 79128 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 1088 1088 0 0.0
.rodata 224200 224200 0 0.0
.text 2626805 2626805 0 0.0
bridge-app debug (read only) 2518637 2518637 0 0.0
(read/write) 129608 129608 0 0.0
.bss 50232 50232 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 69560 69560 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 172840 172840 0 0.0
.text 2173573 2173573 0 0.0
chip-tool debug (read only) 15477097 15477097 0 0.0
(read/write) 704768 704768 0 0.0
.bss 26424 26424 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 668512 668512 0 0.0
.dynamic 608 608 0 0.0
.got 5360 5360 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 683733 683733 0 0.0
.text 13157892 13157892 0 0.0
chip-tool-ipv6only arm64 (read only) 14808708 14808708 0 0.0
(read/write) 757608 757608 0 0.0
.bss 34408 34408 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 698304 698304 0 0.0
.dynamic 560 560 0 0.0
.got 16648 16648 0 0.0
.init 24 24 0 0.0
.init_array 224 224 0 0.0
.rodata 620184 620184 0 0.0
.text 12395956 12395956 0 0.0
dynamic-bridge-app-ipv6only debug (read only) 2567653 2567653 0 0.0
(read/write) 126768 126768 0 0.0
.bss 47544 47544 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 70288 70288 0 0.0
.dynamic 624 624 0 0.0
.got 4792 4792 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 175784 175784 0 0.0
.text 2214629 2214629 0 0.0
lighting-app debug+rpc+ui (read only) 3381241 3381241 0 0.0
(read/write) 135696 135696 0 0.0
.bss 49344 49344 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 76768 76768 0 0.0
.dynamic 656 656 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 286388 286388 0 0.0
.text 2898162 2898162 0 0.0
lock-app debug (read only) 2659829 2659829 0 0.0
(read/write) 123584 123584 0 0.0
.bss 45952 45952 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 69600 69600 0 0.0
.dynamic 608 608 0 0.0
.got 4648 4648 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 206088 206088 0 0.0
.text 2281141 2281141 0 0.0
ota-provider-app debug (read only) 2208669 2208669 0 0.0
(read/write) 103600 103600 0 0.0
.bss 44528 44528 0 0.0
.data 2112 2112 0 0.0
.data.rel.ro 51880 51880 0 0.0
.dynamic 608 608 0 0.0
.got 3800 3800 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 153992 153992 0 0.0
.text 1913253 1913253 0 0.0
ota-requestor-app debug (read only) 2376245 2376245 0 0.0
(read/write) 111392 111392 0 0.0
.bss 46960 46960 0 0.0
.data 2512 2512 0 0.0
.data.rel.ro 56736 56736 0 0.0
.dynamic 608 608 0 0.0
.got 3784 3784 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 158056 158056 0 0.0
.text 2067893 2067893 0 0.0
shell debug (read only) 2773113 2773113 0 0.0
(read/write) 145336 145336 0 0.0
.bss 57704 57704 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 80552 80552 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 199442 199442 0 0.0
.text 2408194 2408194 0 0.0
thermostat-no-ble arm64 (read only) 2605196 2605196 0 0.0
(read/write) 142760 142760 0 0.0
.bss 52344 52344 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 79072 79072 0 0.0
.dynamic 560 560 0 0.0
.got 5512 5512 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 129608 129608 0 0.0
.text 2210596 2210596 0 0.0
tv-app debug (read only) 3313521 3313521 0 0.0
(read/write) 261472 261472 0 0.0
.bss 171232 171232 0 0.0
.data 4080 4080 0 0.0
.data.rel.ro 79424 79424 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 222328 222328 0 0.0
.text 2895106 2895106 0 0.0
tv-casting-app debug (read only) 9058721 9058721 0 0.0
(read/write) 217960 217960 0 0.0
.bss 52064 52064 0 0.0
.data 1744 1744 0 0.0
.data.rel.ro 157600 157600 0 0.0
.dynamic 608 608 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 992 992 0 0.0
.rodata 327596 327596 0 0.0
.text 8305986 8305986 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2496392 2496392 0 0.0
.bss 216304 216304 0 0.0
.data 5144 5144 0 0.0
.text 1459076 1459076 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1190588 1190588 0 0.0
bss 154135 154135 0 0.0
rodata 135612 135612 0 0.0
text 820052 820052 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1450424 1450424 0 0.0
bss 133875 133875 0 0.0
rodata 231672 231672 0 0.0
text 790776 790776 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1131696 1131696 0 0.0
bss 152775 152775 0 0.0
rodata 109424 109424 0 0.0
text 788820 788820 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842096 842096 0 0.0
(read/write) 1726148 1726148 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188684 188684 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2560 2560 0 0.0
.debug_abbrev 1294089 1294089 0 0.0
.debug_aranges 146872 146872 0 0.0
.debug_frame 491068 491068 0 0.0
.debug_info 31666227 31666226 -1 -0.0
.debug_line 3996836 3996836 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2281929 2281929 0 0.0
.debug_rnglists 142551 142551 0 0.0
.debug_str 4316224 4316224 0 0.0
.heap 842096 842096 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 745938 745938 0 0.0
.symtab 476144 476144 0 0.0
.text 0 0 0 0.0
1526516 1526516 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 843424 843424 0 0.0
(read/write) 1662236 1662236 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187356 187356 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2560 2560 0 0.0
.debug_abbrev 1283823 1283823 0 0.0
.debug_aranges 145912 145912 0 0.0
.debug_frame 493056 493056 0 0.0
.debug_info 31218086 31218085 -1 -0.0
.debug_line 4008614 4008614 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2271463 2271463 0 0.0
.debug_rnglists 141316 141316 0 0.0
.debug_str 4301235 4301235 0 0.0
.heap 843424 843424 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 698504 698504 0 0.0
.symtab 459008 459008 0 0.0
.text 1463932 1463932 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849560 849560 0 0.0
(read/write) 1594788 1594788 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 181388 181388 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1121574 1121574 0 0.0
.debug_aranges 136304 136304 0 0.0
.debug_frame 457144 457144 0 0.0
.debug_info 26093341 26093340 -1 -0.0
.debug_line 3587241 3587241 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 2112009 2112009 0 0.0
.debug_rnglists 131338 131338 0 0.0
.debug_str 4115363 4115363 0 0.0
.heap 849560 849560 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 622002 622002 0 0.0
.symtab 424512 424512 0 0.0
.text 1402620 1402620 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 821960 821960 0 0.0
(read/write) 1627964 1627964 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208988 208988 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1103896 1103896 0 0.0
.debug_aranges 134776 134776 0 0.0
.debug_frame 451704 451704 0 0.0
.debug_info 25659344 25659345 1 0.0
.debug_line 3522671 3522671 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 2085429 2085429 0 0.0
.debug_rnglists 129384 129384 0 0.0
.debug_str 4077447 4077447 0 0.0
.heap 821960 821960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 596027 596027 0 0.0
.symtab 416640 416640 0 0.0
.text 1408196 1408196 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1170468 1170468 0 0.0
.bss 99928 99928 0 0.0
.data 852 852 0 0.0
.text 617564 617564 0 0.0
lock-app qpg6105+debug (read/write) 1139852 1139852 0 0.0
.bss 94824 94824 0 0.0
.data 856 856 0 0.0
.text 586952 586952 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1029616 1029616 0 0.0
bss 97548 97548 0 0.0
text 703656 703660 4 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 960012 960012 0 0.0
bss 96072 96072 0 0.0
text 664062 664062 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 928352 928344 -8 -0.0
bss 100308 100308 0 0.0
text 641538 641536 -2 -0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 859596 859596 0 0.0
bss 89968 89968 0 0.0
text 584278 584278 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 875912 875912 0 0.0
bss 90136 90136 0 0.0
text 598900 598900 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 964244 964244 0 0.0
bss 98492 98492 0 0.0
text 677924 677924 0 0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 975624 975624 0 0.0
bss 102740 102740 0 0.0
text 685446 685446 0 0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1033348 1033348 0 0.0
bss 100056 100056 0 0.0
text 722622 722620 -2 -0.0
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1065100 1065100 0 0.0
bss 111140 111140 0 0.0
text 742960 742962 2 0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 915020 915020 0 0.0
bss 90632 90632 0 0.0
text 613260 613260 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 882172 882172 0 0.0
bss 91236 91236 0 0.0
text 606082 606080 -2 -0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 865612 865612 0 0.0
bss 90100 90100 0 0.0
text 590454 590454 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 852408 852408 0 0.0
bss 89900 89900 0 0.0
text 580574 580574 0 0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 848516 848516 0 0.0
bss 89808 89808 0 0.0
text 576156 576158 2 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 893944 893944 0 0.0
bss 90344 90344 0 0.0
text 615118 615116 -2 -0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 889340 889340 0 0.0
bss 90636 90636 0 0.0
text 610058 610060 2 0.0

@yufengwangca
Copy link
Contributor Author

yufengwangca commented Jun 1, 2023 •
edited
Loading

@yufengwangca in https://github.com/project-chip/connectedhomeip/blob/master/.github/workflows/java-tests.yaml#L93 we now have the ability to run java unit tests.

Would we be able to add unit tests for these classes and functionality as well?

Per sync, we plan to add unit tests after all kotlin conversion is complete so that we don't need to worry about how to link and load native lib to JUnit framework

@yufengwangca yufengwangca merged commit e19d9d8 into project-chip:master Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@G-charbel G-charbel G-charbel left review comments

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

Assignees
No one assigned
Labels
controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yufengwangca @andy31415 @G-charbel @jmartinez-silabs