Make java UTF-8 decode more lenient #26886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs and
jmartinez-silabs
pullapprove
bot
requested review from
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
|
PR #26886: Size comparison from e663746 to bf9dca3 Increases (12 builds for esp32, psoc6, telink)
Decreases (10 builds for bl602, bl702, cc32xx, efr32, qpg, telink)
Full report (66 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
May 27, 2023
jmartinez-silabs
approved these changes
May 27, 2023
andy31415
added a commit
to andy31415/connectedhomeip
that referenced
this pull request
May 29, 2023
* Start asking for replace in the java UTF logic * Fix exception reporting: make sure exception is cleared, print out a nice stack trace * Restyle * Fix for compilation * Fix signature for repolace action field * Restyled by clang-format --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Restyled.io <[email protected]>
andy31415
added a commit
that referenced
this pull request
May 29, 2023
* Start asking for replace in the java UTF logic * Fix exception reporting: make sure exception is cleared, print out a nice stack trace * Restyle * Fix for compilation * Fix signature for repolace action field * Restyled by clang-format --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code would throw an exception on invalid UTF8 characters and we found certified devices sending out such invalid data (even though spec mandates utf8). Before this change we would see (with modified test app):
after this we can decode:
for a string of
char bad[] = {0x73, 0x74, 0x61, 0x72, 0x74, 0x75, 0x70, (char)0x91, 0x00};.
Also fixed environment exception check: an exception check was done without clearing the current active exception. Updated code to correctly clear the active exception.
Testing: