-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[matter_yamltests] Replace python 3.9 list/tuple syntax with typing.List/typing.Tuple #26873
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
vivien-apple:MatterYamlTests_ReplacePython3_9listWithTypingList
May 26, 2023
Merged
[matter_yamltests] Replace python 3.9 list/tuple syntax with typing.List/typing.Tuple #26873
bzbarsky-apple
merged 1 commit into
project-chip:master
from
vivien-apple:MatterYamlTests_ReplacePython3_9listWithTypingList
May 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #26873: Size comparison from fd333d1 to 52ea08c Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
vivien-apple
force-pushed
the
MatterYamlTests_ReplacePython3_9listWithTypingList
branch
from
May 26, 2023 10:52
52ea08c
to
db09107
Compare
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
May 26, 2023 10:52
pullapprove
bot
requested review from
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
msandstedt,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
May 26, 2023 10:52
vivien-apple
changed the title
[matter_yamltests] Replace python 3.9 list syntax with typing.List
[matter_yamltests] Replace python 3.9 list/tuple syntax with typing.List/typing.Tuple
May 26, 2023
vivien-apple
force-pushed
the
MatterYamlTests_ReplacePython3_9listWithTypingList
branch
from
May 26, 2023 10:59
db09107
to
6cb1224
Compare
PR #26873: Size comparison from fd333d1 to 6cb1224 Increases (5 builds for cc13x4_26x4, cc32xx, psoc6, telink)
Decreases (17 builds for bl602, bl702, efr32, nrfconnect, psoc6, telink)
Full report (66 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
raju-apple
approved these changes
May 26, 2023
bzbarsky-apple
approved these changes
May 26, 2023
Fast-tracking testing improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In
scripts/py_matter_yamltests/matter_yamltests/__init__.py
the minimum python version is3.7
butscripts/py_matter_yamltests/matter_yamltests
seems to contains specific python3.9
syntax which makes it impossible to run.