[ESP32] Kconfig fixes and link error fix for h2 #26825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provider when secure cert dac provider is selected
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no and
ksperling-apple
pullapprove
bot
requested review from
msandstedt,
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
|
PR #26825: Size comparison from 9f43988 to 0715a97 Increases (7 builds for bl602, bl702, cc32xx, cyw30739, psoc6, telink)
Decreases (8 builds for efr32, esp32, nrfconnect, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
chshu
approved these changes
May 25, 2023
shubhamdp
changed the title
|
PR #26825: Size comparison from 9f43988 to c3228ad Increases (9 builds for bl602, bl702, cyw30739, efr32, esp32, psoc6, telink)
Decreases (9 builds for cc32xx, esp32, nrfconnect, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
May 25, 2023
bzbarsky-apple
approved these changes
May 25, 2023
wqx6
pushed a commit
to wqx6/connectedhomeip
that referenced
this pull request
May 26, 2023
* [ESP32] Do not select factory data provider and device instance info provider when secure cert dac provider is selected * Fix the linker error when building for esp32h2 * Move ieee802154 under openthread config
chshu
pushed a commit
that referenced
this pull request
May 26, 2023
* [ESP32] Do not select factory data provider and device instance info provider when secure cert dac provider is selected * Fix the linker error when building for esp32h2 * Move ieee802154 under openthread config Co-authored-by: Shubham Patil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not select factory data provider and device instance info provider when secure cert dac provider is selected
Someone may want to use the example commissionable data provider and example device instance info provider so do not select the factory impl of same when we are reading attestation data from secure cert.
Also, There were some linking errors for ESP32H2, fixed them
Tests