Fix reporting of event path errors in MTRBaseDevice. #26822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
pullapprove
bot
requested review from
msandstedt,
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
jtung-apple
approved these changes
May 25, 2023
|
PR #26822: Size comparison from 5d459ce to ad234ad Increases (4 builds for bl702, telink)
Decreases (10 builds for bl602, cc32xx, efr32, esp32, telink)
Full report (50 builds for bl602, bl702, cc32xx, efr32, esp32, k32w, linux, mbed, nrfconnect, qpg, telink)
|
|
Fast-tracking platform-specific fix with platform owner review. |
yunhanw-google
approved these changes
May 25, 2023
Two main fixes here: * Don't lose the prceise error if we have one in OnEventData. * Use the right path key in our report dictionary for event errors. The path key problem has not been shipped in any releases before, so no backports needed. The other changes are just aligning the attribute and event cases on checking "is this a path we expected a report for?" before actually looking at the report we got.
bzbarsky-apple
force-pushed
the
fix-event-error-report
branch
from
ad234ad to
fd200bc
Compare
|
PR #26822: Size comparison from e042f75 to fd200bc Increases (9 builds for bl702, esp32, psoc6, telink)
Decreases (9 builds for bl602, cc32xx, efr32, esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two main fixes here:
The path key problem has not been shipped in any releases before, so no backports needed.
The other changes are just aligning the attribute and event cases on checking "is this a path we expected a report for?" before actually looking at the report we got.