-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telink]: Shut down BLE after commissioning window closes #26786
Merged
bzbarsky-apple
merged 8 commits into
project-chip:master
from
s07641069:telink_ble_shutdown_fix
Jun 1, 2023
Merged
[Telink]: Shut down BLE after commissioning window closes #26786
bzbarsky-apple
merged 8 commits into
project-chip:master
from
s07641069:telink_ble_shutdown_fix
Jun 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…timed out Signed-off-by: Misha Tkachenko <[email protected]>
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
May 24, 2023 08:54
PR #26786: Size comparison from e022057 to ff38501 Increases (22 builds for bl602, bl702, efr32, esp32, psoc6, qpg, telink)
Decreases (6 builds for bl602, cc32xx, efr32, nrfconnect, psoc6)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
approved these changes
May 24, 2023
PR #26786: Size comparison from 964a677 to 22396ec Increases (21 builds for bl602, bl702, cyw30739, esp32, telink)
Decreases (6 builds for bl702, cc32xx, efr32, psoc6, qpg)
Full report (66 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #26786: Size comparison from ad5253a to a83d3f1 Increases (20 builds for bl602, esp32, nrfconnect, psoc6, telink)
Decreases (4 builds for bl702, cc32xx, efr32, psoc6)
Full report (66 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #26786: Size comparison from 76baa66 to 6c9aec1 Increases (21 builds for bl602, cc13x2_26x2, cc13x4_26x4, esp32, psoc6, telink)
Decreases (6 builds for bl602, bl702, efr32, psoc6)
Full report (66 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
May 30, 2023
manjunath-grl
pushed a commit
to manjunath-grl/connectedhomeip
that referenced
this pull request
Jun 1, 2023
…ip#26786) * [Telink]: Added delegate to shut down BLE after commissioning window timed out Signed-off-by: Misha Tkachenko <[email protected]> * Restyled by clang-format * [Telink]: Fixed wrong behavior on Commissioning window close Signed-off-by: Misha Tkachenko <[email protected]> * Restyled by whitespace * Restyled by clang-format --------- Signed-off-by: Misha Tkachenko <[email protected]> Co-authored-by: Misha Tkachenko <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Misha Tkachenko <[email protected]>
@bzbarsky-apple I see that all the issues were resolved, could please someone merge this PR? |
sharadb-amazon
pushed a commit
to sharadb-amazon/connectedhomeip
that referenced
this pull request
Jun 21, 2023
…ip#26786) * [Telink]: Added delegate to shut down BLE after commissioning window timed out Signed-off-by: Misha Tkachenko <[email protected]> * Restyled by clang-format * [Telink]: Fixed wrong behavior on Commissioning window close Signed-off-by: Misha Tkachenko <[email protected]> * Restyled by whitespace * Restyled by clang-format --------- Signed-off-by: Misha Tkachenko <[email protected]> Co-authored-by: Misha Tkachenko <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Misha Tkachenko <[email protected]>
sharadb-amazon
pushed a commit
to sharadb-amazon/connectedhomeip
that referenced
this pull request
Jul 13, 2023
…ip#26786) * [Telink]: Added delegate to shut down BLE after commissioning window timed out Signed-off-by: Misha Tkachenko <[email protected]> * Restyled by clang-format * [Telink]: Fixed wrong behavior on Commissioning window close Signed-off-by: Misha Tkachenko <[email protected]> * Restyled by whitespace * Restyled by clang-format --------- Signed-off-by: Misha Tkachenko <[email protected]> Co-authored-by: Misha Tkachenko <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Misha Tkachenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change overview
Testing
After commissioning window timed out performed shut down of BLE.