-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telink]: Update button manager to new gpio IRQ system #26785
Merged
andy31415
merged 7 commits into
project-chip:master
from
s07641069:telink_button_manager_refactoring
May 29, 2023
Merged
[Telink]: Update button manager to new gpio IRQ system #26785
andy31415
merged 7 commits into
project-chip:master
from
s07641069:telink_button_manager_refactoring
May 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Misha Tkachenko <[email protected]>
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs and
jmartinez-silabs
May 24, 2023 08:47
pullapprove
bot
requested review from
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yunhanw-google
May 24, 2023 08:47
PR #26785: Size comparison from e022057 to 87f0520 Increases (7 builds for bl602, bl702, efr32, esp32, psoc6, qpg)
Decreases (6 builds for bl602, cc32xx, efr32, psoc6, qpg)
Full report (42 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
Signed-off-by: Misha Tkachenko <[email protected]>
PR #26785: Size comparison from 9f43988 to cc9ab41 Increases (22 builds for bl602, bl702, esp32, psoc6, telink)
Decreases (4 builds for efr32, esp32, qpg)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
s07641069
changed the title
[Telink]: Updated button manager to new gpio IRQ system
[Telink]: Update button manager to new gpio IRQ system
May 25, 2023
andy31415
approved these changes
May 25, 2023
PR #26785: Size comparison from caf29e5 to 581909c Increases (20 builds for bl702, cyw30739, esp32, psoc6, telink)
Decreases (6 builds for bl602, cc13x4_26x4, efr32, nrfconnect, psoc6)
Full report (66 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@andy31415 Could you process PR? Tests still unstable after merge. Maybe need force run just failed job again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change overview
Testing
Tested button functionality manually with lighting and light-switch (IRQ) examples.