-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[darwin] Ensure the ble timeout for scanning is resumed before trying… #26749
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:DarwinBle_TimerSuspendedTwice
Jul 7, 2023
Merged
[darwin] Ensure the ble timeout for scanning is resumed before trying… #26749
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:DarwinBle_TimerSuspendedTwice
Jul 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo and
jtung-apple
May 23, 2023 15:20
pullapprove
bot
requested review from
tecimovic,
tehampson,
vijs,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
May 23, 2023 15:20
PR #26749: Size comparison from 7f6f27d to 09419c9 Increases (14 builds for bl702, k32w, psoc6, qpg, telink)
Decreases (9 builds for bl602, cyw30739, efr32, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
force-pushed
the
DarwinBle_TimerSuspendedTwice
branch
from
May 24, 2023 14:48
09419c9
to
a80b232
Compare
PR #26749: Size comparison from 5181fc9 to a80b232 Increases (6 builds for cyw30739, esp32, telink)
Decreases (16 builds for bl602, bl702, efr32, esp32, nrfconnect, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
force-pushed
the
DarwinBle_TimerSuspendedTwice
branch
from
May 25, 2023 08:33
a80b232
to
ec123d5
Compare
PR #26749: Size comparison from 9f43988 to ec123d5 Increases (13 builds for bl602, bl702, cyw30739, esp32, psoc6, telink)
Decreases (11 builds for efr32, esp32, nrfconnect, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
force-pushed
the
DarwinBle_TimerSuspendedTwice
branch
from
June 27, 2023 17:29
ec123d5
to
fb79b57
Compare
PR #26749: Size comparison from 3543f06 to fb79b57 Increases (8 builds for esp32, psoc6, telink)
Decreases (9 builds for bl702, k32w, psoc6, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
force-pushed
the
DarwinBle_TimerSuspendedTwice
branch
from
July 4, 2023 08:07
fb79b57
to
ab65a2b
Compare
PR #26749: Size comparison from a85c19f to ab65a2b Increases (10 builds for bl602, cc32xx, psoc6, qpg, telink)
Decreases (4 builds for esp32, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jul 7, 2023
vivien-apple
force-pushed
the
DarwinBle_TimerSuspendedTwice
branch
from
July 7, 2023 15:24
ab65a2b
to
f987a89
Compare
PR #26749: Size comparison from c80c789 to f987a89 Increases (14 builds for bl702, bl702l, cc32xx, esp32, psoc6, qpg, telink)
Decreases (7 builds for bl602, cyw30739, esp32, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to suspend it
Problem
Under darwin when ble scanning starts but ble is turned off it does crash.