-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align General Commissioning cluster XML to spec changes. #26732
Merged
bzbarsky-apple
merged 3 commits into
project-chip:master
from
bzbarsky-apple:rename-general-commissioning
May 23, 2023
Merged
Align General Commissioning cluster XML to spec changes. #26732
bzbarsky-apple
merged 3 commits into
project-chip:master
from
bzbarsky-apple:rename-general-commissioning
May 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
app
controller
darwin
esp32
examples
linux
platform
scripts
labels
May 22, 2023
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs and
jmartinez-silabs
May 22, 2023 20:25
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
younghak-hwang
May 22, 2023 20:25
bzbarsky-apple
force-pushed
the
rename-general-commissioning
branch
from
May 22, 2023 20:35
ca7f954
to
45a05db
Compare
PR #26732: Size comparison from e217219 to 45a05db Increases (14 builds for bl602, bl702, cc32xx, cyw30739, psoc6, qpg, telink)
Decreases (12 builds for bl702, cyw30739, efr32, esp32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
ReneJosefsen
approved these changes
May 22, 2023
bzbarsky-apple
force-pushed
the
rename-general-commissioning
branch
2 times, most recently
from
May 22, 2023 22:50
711af03
to
ef01a85
Compare
PR #26732: Size comparison from 853691d to ef01a85 Increases (14 builds for bl702, cc32xx, esp32, psoc6, telink)
Decreases (11 builds for bl602, efr32, nrfconnect, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
rename-general-commissioning
branch
from
May 23, 2023 00:52
ef01a85
to
6e449c9
Compare
PR #26732: Size comparison from 853691d to 6e449c9 Increases (12 builds for bl702, cc32xx, esp32, psoc6, telink)
Decreases (17 builds for bl602, bl702, cyw30739, efr32, k32w, nrfconnect, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
rename-general-commissioning
branch
from
May 23, 2023 13:00
6e449c9
to
60c19bf
Compare
tcarmelveilleux
approved these changes
May 23, 2023
PR #26732: Size comparison from d1d37ec to 60c19bf Increases (11 builds for bl702, cc32xx, nrfconnect, psoc6, telink)
Decreases (14 builds for bl602, bl702, efr32, k32w, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVIEW NOTE: Only the first of the three commits is manually-created.
Spec changes happened in
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/6179 and
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/6338
Fixes #24997