-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add washer-controls cluster xml and generate zap #26702
Add washer-controls cluster xml and generate zap #26702
Conversation
PR #26702: Size comparison from f55fa96 to 934d0c9 Increases (2 builds for cc32xx, k32w)
Decreases (3 builds for bl702, k32w, nrfconnect)
Full report (14 builds for bl602, bl702, cc32xx, k32w, mbed, nrfconnect, qpg)
|
src/app/zap-templates/zcl/data-model/chip/washer-controls-cluster.xml
Outdated
Show resolved
Hide resolved
@rbultman @abeck-whirlpool please see #26649 |
Do we know why the PR was closed? It looks like it was closed by the PR author without comment. |
This was closed as we were going to do the two PR's one for XML and codegen and another for the server addition (which will be handled by NXP) per the TCC recommendation |
This was closed as we were going to do the two PR's one for XML and codegen and another for the server addition (which will be handled by NXP) per the TCC recommendation |
PR #26702: Size comparison from 43cfe21 to edc8d39 Increases above 0.2%:
Increases (7 builds for bl702, linux, telink)
Decreases (21 builds for bl602, bl702, cc32xx, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
Full report (55 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/app/zap-templates/zcl/data-model/chip/washer-controls-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/washer-controls-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/washer-controls-cluster.xml
Outdated
Show resolved
Hide resolved
edc8d39
to
0749457
Compare
c5d4d42
to
cb27bfa
Compare
PR #26702: Size comparison from 77a92d4 to b61b336 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #26702: Size comparison from e5fd871 to c434b95 Increases (13 builds for bl602, bl702, cc32xx, esp32, linux, psoc6)
Decreases (3 builds for bl702, cyw30739, esp32)
Full report (41 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
src/app/zap-templates/zcl/data-model/chip/washer-controls-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/washer-controls-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/washer-controls-cluster.xml
Outdated
Show resolved
Hide resolved
PR #26702: Size comparison from 81f71a0 to 270bcac Increases (16 builds for bl702, cc32xx, esp32, linux, psoc6, qpg, telink)
Decreases (7 builds for cyw30739, esp32, telink)
Full report (54 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
PR #26702: Size comparison from 1793a4c to 8465947 Increases (6 builds for bl602, bl702, cc32xx, nrfconnect)
Decreases (2 builds for bl702, nrfconnect)
Full report (11 builds for bl602, bl702, cc32xx, mbed, nrfconnect, qpg)
|
PR #26702: Size comparison from 2520f47 to 90d8b23 Increases (22 builds for bl602, bl702, cc32xx, esp32, linux, psoc6, telink)
Decreases (4 builds for telink)
Full report (54 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
PR #26702: Size comparison from 2520f47 to a28ee9b Increases (21 builds for bl602, bl702, cc32xx, esp32, linux, psoc6, telink)
Decreases (3 builds for telink)
Full report (54 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
PR #26702: Size comparison from 88f02e6 to 9b2b1d9 Increases (4 builds for bl702, cc32xx, linux)
Decreases (2 builds for bl702, qpg)
Full report (10 builds for bl602, bl702, cc32xx, linux, mbed, qpg)
|
PR #26702: Size comparison from f6c1a89 to 79469d4 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #26702: Size comparison from 42b424d to fc5f888 Increases (16 builds for bl702, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Decreases (7 builds for bl702, cyw30739, qpg, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #26702: Size comparison from 580c8e0 to 64a0fb4 Increases (4 builds for bl702, cc32xx, nrfconnect)
Decreases (4 builds for bl602, mbed, nrfconnect)
Full report (9 builds for bl602, bl702, cc32xx, mbed, nrfconnect)
|
PR #26702: Size comparison from dd21e4e to 9ca9047 Increases (20 builds for bl602, bl702, cc32xx, cyw30739, esp32, linux, psoc6, qpg, telink)
Decreases (4 builds for bl702, telink)
Full report (53 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, psoc6, qpg, telink)
|
Changes:
Add washer-controls cluster xml and generate zap.
Testing
Build all-clusters-app, chip-tool
Notes:
This contains changes for an in flight PR to address issues with Washer Controls which can be found here https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7029