-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase timeout value for door lock test from 15s to 25s. #26659
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-lock-timeouts
May 18, 2023
Merged
Increase timeout value for door lock test from 15s to 25s. #26659
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-lock-timeouts
May 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
May 18, 2023 14:09
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
May 18, 2023 14:10
cecille
approved these changes
May 18, 2023
jmartinez-silabs
approved these changes
May 18, 2023
PR #26659: Size comparison from c520917 to a2db5eb Increases (2 builds for k32w, psoc6)
Decreases (9 builds for bl702, cc32xx, efr32, k32w, nrfconnect, psoc6)
Full report (40 builds for bl602, bl702, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
The test has a 10-second wait built in, and it's possible for us to spend more than 5s running the rest of it, at which point it times out.
bzbarsky-apple
force-pushed
the
fix-lock-timeouts
branch
from
May 18, 2023 15:35
a2db5eb
to
5863251
Compare
andy31415
approved these changes
May 18, 2023
PR #26659: Size comparison from e230ee1 to 5863251 Increases (11 builds for bl602, bl702, nrfconnect, psoc6, telink)
Decreases (10 builds for bl702, efr32, esp32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test has a 10-second wait built in, and it's possible for us to spend more than 5s running the rest of it, at which point it times out.