-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove no-longer-needed Darwin removal annotations. #26636
Merged
bzbarsky-apple
merged 3 commits into
project-chip:master
from
bzbarsky-apple:remove-removed-annotations
May 17, 2023
Merged
Remove no-longer-needed Darwin removal annotations. #26636
bzbarsky-apple
merged 3 commits into
project-chip:master
from
bzbarsky-apple:remove-removed-annotations
May 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock and
kkasperczyk-no
May 17, 2023 16:19
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple and
xylophone21
May 17, 2023 16:19
andy31415
approved these changes
May 17, 2023
jtung-apple
approved these changes
May 17, 2023
PR #26636: Size comparison from 5a3e7a3 to efb028e Increases (10 builds for bl602, cc32xx, cyw30739, esp32, nrfconnect, psoc6, telink)
Decreases (11 builds for bl602, bl702, efr32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Now that isSupported returns false for things that are introduced after a container's deprecation, a bunch of removal annotations are no longer needed. Also: * Adds the missing deprecation for BridgedDeviceBasic. * Adds linux-arm64 ZAP now that it's available.
bzbarsky-apple
force-pushed
the
remove-removed-annotations
branch
from
May 17, 2023 19:29
efb028e
to
e9bcb2d
Compare
PR #26636: Size comparison from db088d5 to e9bcb2d Increases (14 builds for bl602, cc32xx, cyw30739, esp32, nrfconnect, psoc6, telink)
Decreases (10 builds for bl702, cyw30739, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
farshidtz
added a commit
to farshidtz/connectedhomeip
that referenced
this pull request
Feb 1, 2024
Remove arm64 since it is done automatically since project-chip#26636
This was referenced Feb 1, 2024
bzbarsky-apple
pushed a commit
that referenced
this pull request
Apr 24, 2024
* Update ZAP installation description Remove arm64 since it is done automatically since #26636 * Improve explanations, describe the CIDP process * Improve link texts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that isSupported returns false for things that are introduced after a container's deprecation, a bunch of removal annotations are no longer needed.
Also: