-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Group][Transport] Add Random first value group counter #26610
Merged
jepenven-silabs
merged 2 commits into
project-chip:master
from
jepenven-silabs:fix_group_msg_counter_random_init
May 24, 2023
Merged
[Group][Transport] Add Random first value group counter #26610
jepenven-silabs
merged 2 commits into
project-chip:master
from
jepenven-silabs:fix_group_msg_counter_random_init
May 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
May 16, 2023 15:35
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
May 16, 2023 15:35
PR #26610: Size comparison from 72e7659 to fb7bfe7 Increases above 0.2%:
Increases (35 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (3 builds for bl702, esp32)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
requested changes
May 16, 2023
PR #26610: Size comparison from 72e7659 to b496055 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
jepenven-silabs
force-pushed
the
fix_group_msg_counter_random_init
branch
from
May 16, 2023 19:17
b496055
to
a34a5a8
Compare
PR #26610: Size comparison from 06921da to a34a5a8 Increases above 0.2%:
Increases (54 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for bl702)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jepenven-silabs
force-pushed
the
fix_group_msg_counter_random_init
branch
from
May 17, 2023 11:05
a34a5a8
to
a046955
Compare
PR #26610: Size comparison from 64bf867 to a046955 Increases (54 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for bl702)
Full report (54 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
May 17, 2023
lpbeliveau-silabs
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the TODO.