-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make pigweed set up clang-format on M1/M2 macs as well. #26579
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:install-clang-format-on-M1
May 15, 2023
Merged
Make pigweed set up clang-format on M1/M2 macs as well. #26579
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:install-clang-format-on-M1
May 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way our codegen works right now expects everyone to be able to run the same version of clang-format from the pigweed setup. But pigweed by default does not install clang (and hence clang-format) on ARM macs. This adds the ARM mac version of clang to the set of things we install in addition to the default pigweed bits. The SHA is unfortunately hardcoded to match the current SHA that pigweed uses on other platforms, but the lint should make sure we don't break that.
bzbarsky-apple
force-pushed
the
install-clang-format-on-M1
branch
from
May 15, 2023 16:08
70755a0
to
730a842
Compare
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
May 15, 2023 16:08
pullapprove
bot
requested review from
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
msandstedt,
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang and
yufengwangca
May 15, 2023 16:08
PR #26579: Size comparison from b4fb147 to 730a842 Increases (9 builds for bl702, cc32xx, psoc6, telink)
Decreases (9 builds for cyw30739, esp32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way our codegen works right now expects everyone to be able to run the same version of clang-format from the pigweed setup. But pigweed by default does not install clang (and hence clang-format) on ARM macs.
This adds the ARM mac version of clang to the set of things we install in addition to the default pigweed bits. The SHA is unfortunately hardcoded to match the current SHA that pigweed uses on other platforms, but the lint should make sure we don't break that.