-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix isUpperCase/isLowerCase constraint checking in python yaml processing. #26536
Merged
bzbarsky-apple
merged 3 commits into
project-chip:master
from
bzbarsky-apple:fix-python-case-constraint-check
May 15, 2023
Merged
Fix isUpperCase/isLowerCase constraint checking in python yaml processing. #26536
bzbarsky-apple
merged 3 commits into
project-chip:master
from
bzbarsky-apple:fix-python-case-constraint-check
May 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock and
kkasperczyk-no
May 12, 2023 06:42
pullapprove
bot
requested review from
msandstedt,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
May 12, 2023 06:42
PR #26536: Size comparison from a3b4005 to a8a8659 Full report (1 build for cc32xx)
|
…sing. I just got a CI failure like so: TEST OUT: isUpperCase: true <-- The response "9659674627744477" contains lowercase characters: []. but of course it does not. It just happens to be an instance name that didn't end up using any hex chars that are > 9. This change better aligns the way Python tests uppercase/lowercase with the built-in chip-tool constraint impl.
bzbarsky-apple
force-pushed
the
fix-python-case-constraint-check
branch
from
May 12, 2023 13:18
a8a8659
to
fc46770
Compare
andy31415
reviewed
May 12, 2023
andy31415
approved these changes
May 12, 2023
PR #26536: Size comparison from bbff46a to fc46770 Increases (7 builds for bl602, efr32, esp32, linux, nrfconnect, psoc6)
Decreases (7 builds for bl702, cc32xx, esp32, nrfconnect, psoc6)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
vivien-apple
approved these changes
May 12, 2023
PR #26536: Size comparison from bbff46a to 709845e Increases above 0.2%:
Increases (12 builds for bl602, bl702, efr32, esp32, linux, nrfconnect, psoc6)
Decreases (14 builds for bl702, cc32xx, linux, nrfconnect)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just got a CI failure like so:
TEST OUT: isUpperCase: true <-- The response "9659674627744477" contains lowercase characters: [].
but of course it does not. It just happens to be an instance name that didn't end up using any hex chars that are > 9.
This change better aligns the way Python tests uppercase/lowercase with the built-in chip-tool constraint impl.