Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Nullable::HasValidValue so people won't try to use it. #26535

Merged
merged 1 commit into from
May 16, 2023
Merged

Rename Nullable::HasValidValue so people won't try to use it. #26535

merged 1 commit into from
May 16, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

This function is a pretty specific thing, and people are confusing it with IsNull(). Rename to something that will make it less likely.

@github-actions
Copy link

PR #26535: Size comparison from a3b4005 to a4ec3a5

Increases (1 build for cc32xx)
platform target config section a3b4005 a4ec3a5 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_str 3131974 3132822 848 0.0
.strtab 483172 483188 16 0.0
Full report (1 build for cc32xx)
platform target config section a3b4005 a4ec3a5 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 605018 605018 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 958615 958615 0 0.0
.debug_aranges 101232 101232 0 0.0
.debug_frame 342084 342084 0 0.0
.debug_info 19678442 19678442 0 0.0
.debug_line 2673606 2673606 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1491157 1491157 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94412 94412 0 0.0
.debug_str 3131974 3132822 848 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104322 104322 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483172 483188 16 0.0
.symtab 287232 287232 0 0.0
.text 498572 498572 0 0.0

@bzbarsky-apple
Rename Nullable::HasValidValue so people won't try to use it.
1be1b68 
This function is a pretty specific thing, and people are confusing it with
IsNull().  Rename to something that will make it less likely.
@bzbarsky-apple bzbarsky-apple force-pushed the rename-HasValidValue branch from a4ec3a5 to 1be1b68 Compare May 12, 2023 13:18
@github-actions
Copy link

github-actions bot commented May 12, 2023 •
edited
Loading

PR #26535: Size comparison from bbff46a to 1be1b68

Increases (11 builds for bl602, bl702, cc32xx, esp32, nrfconnect, psoc6)
platform target config section bbff46a 1be1b68 change % change
bl602 lighting-app bl602+rpc .text 1067342 1067344 2 0.0
bl702 lighting-app bl702 .debug_str 3708369 3709217 848 0.0
bl702+rpc .debug_str 4133474 4134322 848 0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_str 3131974 3132822 848 0.0
.strtab 483172 483188 16 0.0
esp32 all-clusters-app c3devkit (read only) 1053036 1053038 2 0.0
.flash.text 1053036 1053038 2 0.0
m5stack (read/write) 492582 492586 4 0.0
.flash.rodata 240976 240980 4 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 807280 807284 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_str 3640280 3641128 848 0.0
.strtab 716254 716270 16 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_str 3631982 3632830 848 0.0
.strtab 674942 674958 16 0.0
light cy8ckit_062s2_43012 .debug_str 3437961 3438809 848 0.0
.strtab 590995 591011 16 0.0
lock cy8ckit_062s2_43012 .debug_info 22488412 22488413 1 0.0
.debug_str 3452943 3453791 848 0.0
.strtab 594996 595012 16 0.0
Decreases (7 builds for bl702, cc13x2_26x2, cc32xx, psoc6, qpg)
platform target config section bbff46a 1be1b68 change % change
bl702 lighting-app bl702 .debug_info 40947052 40947051 -1 -0.0
.text 965480 965478 -2 -0.0
bl702+rpc .debug_info 45852869 45852867 -2 -0.0
.text 1038108 1038104 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 678967 678959 -8 -0.0
.text 591864 591856 -8 -0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19678443 19678442 -1 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27010788 27010787 -1 -0.0
light cy8ckit_062s2_43012 .debug_info 22308529 22308528 -1 -0.0
qpg lighting-app qpg6105+debug (read/write) 1169632 1169624 -8 -0.0
.text 616732 616724 -8 -0.0
Full report (49 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
platform target config section bbff46a 1be1b68 change % change
bl602 lighting-app bl602 (read/write) 1355010 1355010 0 0.0
.bss 87886 87886 0 0.0
.data 9648 9648 0 0.0
.text 1035986 1035986 0 0.0
bl602+rpc (read/write) 1401278 1401278 0 0.0
.bss 95934 95934 0 0.0
.data 10040 10040 0 0.0
.text 1067342 1067344 2 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1185791 1185791 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67585 67585 0 0.0
.bss_psram 24368 24368 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1551184 1551184 0 0.0
.debug_aranges 132944 132944 0 0.0
.debug_frame 488808 488808 0 0.0
.debug_info 40947052 40947051 -1 -0.0
.debug_line 5303308 5303308 0 0.0
.debug_loc 3424642 3424642 0 0.0
.debug_ranges 372344 372344 0 0.0
.debug_str 3708369 3709217 848 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106320 106320 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 580869 580869 0 0.0
.symtab 175264 175264 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
965480 965478 -2 -0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1273571 1273571 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75633 75633 0 0.0
.bss_psram 24768 24768 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1707934 1707934 0 0.0
.debug_aranges 141224 141224 0 0.0
.debug_frame 516780 516780 0 0.0
.debug_info 45852869 45852867 -2 -0.0
.debug_line 5718212 5718212 0 0.0
.debug_loc 3626890 3626890 0 0.0
.debug_ranges 397648 397648 0 0.0
.debug_str 4133474 4134322 848 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 120144 120144 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 641539 641539 0 0.0
.symtab 193600 193600 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1038108 1038104 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 678967 678959 -8 -0.0
(read/write) 158620 158620 0 0.0
.bss 81192 81192 0 0.0
.data 3316 3316 0 0.0
.rodata 86783 86783 0 0.0
.text 591864 591856 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 644847 644847 0 0.0
(read/write) 157860 157860 0 0.0
.bss 80432 80432 0 0.0
.data 3316 3316 0 0.0
.rodata 76767 76767 0 0.0
.text 567760 567760 0 0.0
lock-ftd LP_CC2652R7 (read only) 680023 680023 0 0.0
(read/write) 156136 156136 0 0.0
.bss 78744 78744 0 0.0
.data 3280 3280 0 0.0
.rodata 75639 75639 0 0.0
.text 603896 603896 0 0.0
lock-mtd LP_CC2652R7 (read only) 667427 667427 0 0.0
(read/write) 151312 151312 0 0.0
.bss 73920 73920 0 0.0
.data 3280 3280 0 0.0
.rodata 102467 102467 0 0.0
.text 564472 564472 0 0.0
pump-app LP_CC2652R7 (read only) 692635 692635 0 0.0
(read/write) 156588 156588 0 0.0
.bss 78720 78720 0 0.0
.data 3244 3244 0 0.0
.rodata 89763 89763 0 0.0
.text 602384 602384 0 0.0
pump-controller-app LP_CC2652R7 (read only) 678115 678115 0 0.0
(read/write) 157004 157004 0 0.0
.bss 78856 78856 0 0.0
.data 3268 3268 0 0.0
.rodata 85531 85531 0 0.0
.text 592096 592096 0 0.0
shell LP_CC2652R7 (read only) 672166 672166 0 0.0
(read/write) 160692 160692 0 0.0
.bss 83280 83280 0 0.0
.data 3300 3300 0 0.0
.rodata 85078 85078 0 0.0
.text 586764 586764 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 605018 605018 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 958615 958615 0 0.0
.debug_aranges 101232 101232 0 0.0
.debug_frame 342084 342084 0 0.0
.debug_info 19678443 19678442 -1 -0.0
.debug_line 2673606 2673606 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1491157 1491157 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 94412 94412 0 0.0
.debug_str 3131974 3132822 848 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104322 104322 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483172 483188 16 0.0
.symtab 287232 287232 0 0.0
.text 498572 498572 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 524283 524283 0 0.0
.app_xip_area 417077 417077 0 0.0
.bss 62184 62184 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 528963 528963 0 0.0
.app_xip_area 416453 416453 0 0.0
.bss 67480 67480 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566115 566115 0 0.0
.app_xip_area 459669 459669 0 0.0
.bss 61472 61472 0 0.0
.data 668 668 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 530875 530875 0 0.0
.app_xip_area 421861 421861 0 0.0
.bss 63960 63960 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 964076 964076 0 0.0
.bss 179672 179672 0 0.0
.data 2136 2136 0 0.0
.text 782248 782248 0 0.0
BRD4187C (read/write) 1000776 1000776 0 0.0
.bss 159420 159420 0 0.0
.data 2780 2780 0 0.0
.text 838556 838556 0 0.0
lock-app BRD4161A+wf200 (read/write) 1068604 1068604 0 0.0
.bss 174144 174144 0 0.0
.data 2152 2152 0 0.0
.text 892288 892288 0 0.0
window-app BRD4187C (read/write) 1075816 1075816 0 0.0
.bss 143876 143876 0 0.0
.data 2676 2676 0 0.0
.text 929244 929244 0 0.0
esp32 all-clusters-app c3devkit (read only) 1053036 1053038 2 0.0
(read/write) 1583400 1583400 0 0.0
.dram0.bss 77136 77136 0 0.0
.dram0.data 13968 13968 0 0.0
.flash.rodata 213168 213168 0 0.0
.flash.text 1053036 1053038 2 0.0
.iram0.text 76708 76708 0 0.0
m5stack (read only) 1100919 1100919 0 0.0
(read/write) 492582 492586 4 0.0
.dram0.bss 82152 82152 0 0.0
.dram0.data 34304 34304 0 0.0
.flash.rodata 240976 240980 4 0.0
.flash.text 1095535 1095535 0 0.0
.iram0.text 126055 126055 0 0.0
k32w contact k32w0+release (read only) 583460 583460 0 0.0
(read/write) 82704 82704 0 0.0
.bss 65888 65888 0 0.0
.data 2192 2192 0 0.0
.text 582924 582924 0 0.0
light k32w0+release (read only) 582316 582316 0 0.0
(read/write) 82356 82356 0 0.0
.bss 65552 65552 0 0.0
.data 2180 2180 0 0.0
.text 581780 581780 0 0.0
lock k32w0+release (read only) 555836 555836 0 0.0
(read/write) 80352 80352 0 0.0
.bss 63624 63624 0 0.0
.data 2104 2104 0 0.0
.text 555300 555300 0 0.0
linux all-clusters-app debug (read only) 3147937 3147937 0 0.0
(read/write) 156344 156344 0 0.0
.bss 63584 63584 0 0.0
.data 2144 2144 0 0.0
.data.rel.ro 84024 84024 0 0.0
.dynamic 608 608 0 0.0
.got 4768 4768 0 0.0
.init 27 27 0 0.0
.init_array 1200 1200 0 0.0
.rodata 230363 230363 0 0.0
.text 2730434 2730434 0 0.0
all-clusters-minimal-app debug (read only) 2961553 2961553 0 0.0
(read/write) 149560 149560 0 0.0
.bss 62752 62752 0 0.0
.data 2112 2112 0 0.0
.data.rel.ro 78200 78200 0 0.0
.dynamic 608 608 0 0.0
.got 4704 4704 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 224123 224123 0 0.0
.text 2553698 2553698 0 0.0
bridge-app debug (read only) 2524945 2524945 0 0.0
(read/write) 133456 133456 0 0.0
.bss 53568 53568 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 69944 69944 0 0.0
.dynamic 608 608 0 0.0
.got 4608 4608 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 173096 173096 0 0.0
.text 2178098 2178098 0 0.0
chip-tool debug (read only) 12974833 12974833 0 0.0
(read/write) 695592 695592 0 0.0
.bss 26424 26424 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 659336 659336 0 0.0
.dynamic 608 608 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 623021 623021 0 0.0
.text 10734580 10734580 0 0.0
chip-tool-ipv6only arm64 (read only) 12259756 12259756 0 0.0
(read/write) 746696 746696 0 0.0
.bss 34392 34392 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 688336 688336 0 0.0
.dynamic 560 560 0 0.0
.got 15752 15752 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 570208 570208 0 0.0
.text 9916804 9916804 0 0.0
dynamic-bridge-app-ipv6only debug (read only) 2588657 2588657 0 0.0
(read/write) 130616 130616 0 0.0
.bss 50848 50848 0 0.0
.data 2864 2864 0 0.0
.data.rel.ro 70520 70520 0 0.0
.dynamic 624 624 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 175912 175912 0 0.0
.text 2233954 2233954 0 0.0
lighting-app debug+rpc+ui (read only) 3251505 3251505 0 0.0
(read/write) 136200 136200 0 0.0
.bss 51520 51520 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 75032 75032 0 0.0
.dynamic 656 656 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 284532 284532 0 0.0
.text 2773778 2773778 0 0.0
lock-app debug (read only) 2663833 2663833 0 0.0
(read/write) 127584 127584 0 0.0
.bss 49440 49440 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 69992 69992 0 0.0
.dynamic 608 608 0 0.0
.got 4688 4688 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 206200 206200 0 0.0
.text 2283506 2283506 0 0.0
ota-provider-app debug (read only) 2216857 2216857 0 0.0
(read/write) 107256 107256 0 0.0
.bss 47648 47648 0 0.0
.data 2112 2112 0 0.0
.data.rel.ro 52264 52264 0 0.0
.dynamic 608 608 0 0.0
.got 3840 3840 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 154440 154440 0 0.0
.text 1919490 1919490 0 0.0
ota-requestor-app debug (read only) 2383777 2383777 0 0.0
(read/write) 114952 114952 0 0.0
.bss 50016 50016 0 0.0
.data 2512 2512 0 0.0
.data.rel.ro 57128 57128 0 0.0
.dynamic 608 608 0 0.0
.got 3824 3824 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 158504 158504 0 0.0
.text 2073474 2073474 0 0.0
shell debug (read only) 2673993 2673993 0 0.0
(read/write) 140808 140808 0 0.0
.bss 58984 58984 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 74760 74760 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 197202 197202 0 0.0
.text 2315010 2315010 0 0.0
thermostat-no-ble arm64 (read only) 2528372 2528372 0 0.0
(read/write) 145816 145816 0 0.0
.bss 56392 56392 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 78048 78048 0 0.0
.dynamic 560 560 0 0.0
.got 5472 5472 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 130184 130184 0 0.0
.text 2133456 2133456 0 0.0
tv-app debug (read only) 3308633 3308633 0 0.0
(read/write) 261256 261256 0 0.0
.bss 170976 170976 0 0.0
.data 4080 4080 0 0.0
.data.rel.ro 79456 79456 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1088 1088 0 0.0
.rodata 220824 220824 0 0.0
.text 2891698 2891698 0 0.0
tv-casting-app debug (read only) 6801553 6801553 0 0.0
(read/write) 185584 185584 0 0.0
.bss 52096 52096 0 0.0
.data 1744 1744 0 0.0
.data.rel.ro 125192 125192 0 0.0
.dynamic 608 608 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 1000 1000 0 0.0
.rodata 308684 308684 0 0.0
.text 6147938 6147938 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2495064 2495064 0 0.0
.bss 216304 216304 0 0.0
.data 5144 5144 0 0.0
.text 1457748 1457748 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1176356 1176356 0 0.0
bss 155563 155563 0 0.0
rodata 132756 132756 0 0.0
text 807280 807284 4 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1436084 1436084 0 0.0
bss 135303 135303 0 0.0
rodata 228772 228772 0 0.0
text 777944 777944 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1123464 1123464 0 0.0
bss 154757 154757 0 0.0
rodata 109752 109752 0 0.0
text 778220 778220 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840680 840680 0 0.0
(read/write) 1706636 1706636 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 190108 190108 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2552 2552 0 0.0
.debug_abbrev 1285336 1285336 0 0.0
.debug_aranges 128296 128296 0 0.0
.debug_frame 425812 425812 0 0.0
.debug_info 27010788 27010787 -1 -0.0
.debug_line 3761460 3761460 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2021763 2021763 0 0.0
.debug_rnglists 128096 128096 0 0.0
.debug_str 3640280 3641128 848 0.0
.heap 840680 840680 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 716254 716270 16 0.0
.symtab 466336 466336 0 0.0
.text 0 0 0 0.0
1505588 1505588 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841440 841440 0 0.0
(read/write) 1648964 1648964 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189348 189348 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2552 2552 0 0.0
.debug_abbrev 1280142 1280142 0 0.0
.debug_aranges 127768 127768 0 0.0
.debug_frame 428880 428880 0 0.0
.debug_info 26786851 26786851 0 0.0
.debug_line 3784161 3784161 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2014857 2014857 0 0.0
.debug_rnglists 127260 127260 0 0.0
.debug_str 3631982 3632830 848 0.0
.heap 841440 841440 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 674942 674958 16 0.0
.symtab 451648 451648 0 0.0
.text 1448676 1448676 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849736 849736 0 0.0
(read/write) 1570596 1570596 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 181220 181220 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2384 2384 0 0.0
.debug_abbrev 1112592 1112592 0 0.0
.debug_aranges 117920 117920 0 0.0
.debug_frame 392116 392116 0 0.0
.debug_info 22308529 22308528 -1 -0.0
.debug_line 3347159 3347159 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 1846371 1846371 0 0.0
.debug_rnglists 116889 116889 0 0.0
.debug_str 3437961 3438809 848 0.0
.heap 849736 849736 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 590995 591011 16 0.0
.symtab 414096 414096 0 0.0
.text 1378604 1378604 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 821952 821952 0 0.0
(read/write) 1627100 1627100 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208996 208996 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1111608 1111608 0 0.0
.debug_aranges 118424 118424 0 0.0
.debug_frame 394208 394208 0 0.0
.debug_info 22488412 22488413 1 0.0
.debug_line 3343541 3343541 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 1859798 1859798 0 0.0
.debug_rnglists 117345 117345 0 0.0
.debug_str 3452943 3453791 848 0.0
.heap 821952 821952 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 594996 595012 16 0.0
.symtab 416400 416400 0 0.0
.text 1407324 1407324 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1169632 1169624 -8 -0.0
.bss 99632 99632 0 0.0
.data 856 856 0 0.0
.text 616732 616724 -8 -0.0
lock-app qpg6105+debug (read/write) 1139500 1139500 0 0.0
.bss 94824 94824 0 0.0
.data 856 856 0 0.0
.text 586600 586600 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 5d033a5 into project-chip:master May 16, 2023
@bzbarsky-apple bzbarsky-apple deleted the rename-HasValidValue branch May 16, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@andy31415 andy31415 Awaiting requested review from andy31415

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

Assignees
No one assigned
Labels
app examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzbarsky-apple @andy31415 @jmartinez-silabs @jtung-apple