-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve discovery logging in SetUpCodePairer. #26534
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:better-pairer-logging
May 16, 2023
Merged
Improve discovery logging in SetUpCodePairer. #26534
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:better-pairer-logging
May 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
May 12, 2023 04:43
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
younghak-hwang
May 12, 2023 04:43
PR #26534: Size comparison from a3b4005 to c12a324 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
We should log why we are ignoring discovered devices.
bzbarsky-apple
force-pushed
the
better-pairer-logging
branch
from
May 12, 2023 13:17
c12a324
to
97777f1
Compare
andy31415
approved these changes
May 12, 2023
PR #26534: Size comparison from bbff46a to 97777f1 Increases (10 builds for bl602, bl702, efr32, esp32, linux, nrfconnect, psoc6)
Decreases (2 builds for cc32xx, psoc6)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
jmartinez-silabs
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should log why we are ignoring discovered devices.